Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1128)

#27661: Add tzinfo= argument to datetime.combine

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by alexander.belopolsky
Modified:
1 year, 2 months ago
Reviewers:
ghost.adh, berker.peksag
CC:
sasha, SilentGhost, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/datetime.rst View 1 2 1 chunk +12 lines, -5 lines 0 comments Download
Lib/datetime.py View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
Lib/test/datetimetester.py View 1 2 1 chunk +8 lines, -1 line 0 comments Download
Misc/NEWS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
Modules/_datetimemodule.c View 1 2 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 6
SilentGhost
Also, documentation seems to be missing. https://bugs.python.org/review/27661/diff/18026/Lib/datetime.py File Lib/datetime.py (right): https://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482 Lib/datetime.py:1482: def combine(cls, date, ...
1 year, 2 months ago #1
berkerpeksag
http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py File Lib/datetime.py (right): http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482 Lib/datetime.py:1482: def combine(cls, date, time, tzinfo=True): On 2016/08/01 08:47:14, SilentGhost ...
1 year, 2 months ago #2
sasha
http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py File Lib/datetime.py (right): http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482 Lib/datetime.py:1482: def combine(cls, date, time, tzinfo=True): On 2016/08/01 08:47:14, SilentGhost ...
1 year, 2 months ago #3
SilentGhost
https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst File Doc/library/datetime.rst (right): https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst#newcode801 Doc/library/datetime.rst:801: attributes are equal to the given :class:`.time` object'. If ...
1 year, 2 months ago #4
sasha
https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst File Doc/library/datetime.rst (right): https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst#newcode801 Doc/library/datetime.rst:801: attributes are equal to the given :class:`.time` object'. If ...
1 year, 2 months ago #5
SilentGhost
1 year, 2 months ago #6
https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst
File Doc/library/datetime.rst (right):

https://bugs.python.org/review/27661/diff/18029/Doc/library/datetime.rst#newc...
Doc/library/datetime.rst:803: of the result, otherwise the :attr:`.tzinfo`
attribute of the *time* argument
On 2016/08/01 19:00:04, sasha wrote:
> On 2016/08/01 18:50:06, SilentGhost wrote:
> > This :attr: links to datetime.tzinfo, shouldn't it be linking to
time.tzinfo? 
> 
> Probably.  Do you know how to achieve that in ReST?
:attr:`~.time.tzinfo` should do it
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7