Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

#27640: add the '--disable-test-suite' option to configure

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by xdegaye
Modified:
3 years, 8 months ago
Reviewers:
vadmium+py
CC:
doko, haypo, Martin Panter, thomas-petazzoni, emorley_mozilla.com, Alex.Willmer
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
configure.ac View 1 chunk +12 lines, -0 lines 1 comment Download
Makefile.pre.in View 4 chunks +35 lines, -31 lines 1 comment Download

Messages

Total messages: 1
Martin Panter
3 years, 8 months ago #1
https://bugs.python.org/review/27640/diff/17998/Makefile.pre.in
File Makefile.pre.in (right):

https://bugs.python.org/review/27640/diff/17998/Makefile.pre.in#newcode1252
Makefile.pre.in:1252: @if test "x@WITH_TEST_SUITE@" = xyes; then \
Same comment about the x prefix. I think it should be

test "@WITH_TEST_SUITE@" = yes

https://bugs.python.org/review/27640/diff/17998/configure.ac
File configure.ac (right):

https://bugs.python.org/review/27640/diff/17998/configure.ac#newcode209
configure.ac:209: if test "x$enable_test_suite" = xno; then
I suspect you can drop the x prefix and just write

if test "$enable_test_suite" = no; then

At least in Posix shell, the double quote signs ensure that the variable always
expands as a single argument, even if it is an empty string.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+