Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

#27575: dict viewkeys intersection slow for large dicts

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by dysu1995
Modified:
5 months ago
Reviewers:
shadowranger+python, fgregg
CC:
rhettinger, Mali Akmanalp, dysu1995_gmail.com, fgregg
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/dictobject.c View 1 chunk +74 lines, -6 lines 2 comments Download

Messages

Total messages: 2
Josh.R
Making the comments now, so they can be incorporated into a future pull request. https://bugs.python.org/review/27575/diff/18027/Objects/dictobject.c ...
5 months ago #1
fgregg
5 months ago #2
https://bugs.python.org/review/27575/diff/18027/Objects/dictobject.c
File Objects/dictobject.c (right):

https://bugs.python.org/review/27575/diff/18027/Objects/dictobject.c#newcode3491
Objects/dictobject.c:3491: return _PyObject_CallMethodIdObjArgs(other,
&PyId_intersection, self, NULL);
On 2018/06/14 23:04:53, Josh.R wrote:
> Reusing the intersection method will change behavior when operating against
> frozensets; original behavior was that, when dictview was responsible for the
> operation, the result was *always* set, no matter the type of the other
operand.
> This will change the behavior to return frozenset when the non-view operand is
a
> frozenset, rather than returning set.

Thanks for flagging this! Would you mind making future comments on
https://github.com/python/cpython/pull/7696?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7