Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

#27364: Deprecate invalid unicode escape sequences

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by barry
Modified:
1 year, 3 months ago
Reviewers:
storchaka+cpython, vadmium+py, rdmurray
CC:
gvanrossum, terry.reedy, jaraco, haypo, ezio.melotti, r.david.murray, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, ztane, jayvdb, Chi Hsuan Yen, ebarry
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Patch Set 3 #

Total comments: 1

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 1

Patch Set 7 #

Patch Set 8 #

Total comments: 3

Patch Set 9 #

Total comments: 9

Patch Set 10 #

Patch Set 11 #

Patch Set 12 #

Patch Set 13 #

Patch Set 14 #

Total comments: 5

Patch Set 15 #

Patch Set 16 #

Patch Set 17 #

Total comments: 1

Patch Set 18 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Python/ast.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15
storchaka
http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py File Lib/email/feedparser.py (right): http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py#newcode33 Lib/email/feedparser.py:33: NLCRE_eol = re.compile('(\r\n|\r|\n)\\Z') Why not raw string? http://bugs.python.org/review/27364/diff/17705/Lib/html/parser.py File ...
1 year, 5 months ago #1
ebarry
http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py File Lib/email/feedparser.py (right): http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py#newcode33 Lib/email/feedparser.py:33: NLCRE_eol = re.compile('(\r\n|\r|\n)\\Z') On 2016/06/24 07:17:06, storchaka wrote: > ...
1 year, 5 months ago #2
storchaka
http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py File Lib/email/feedparser.py (right): http://bugs.python.org/review/27364/diff/17705/Lib/email/feedparser.py#newcode33 Lib/email/feedparser.py:33: NLCRE_eol = re.compile('(\r\n|\r|\n)\\Z') On 2016/06/24 07:19:57, ebarry wrote: > ...
1 year, 5 months ago #3
Martin Panter
https://bugs.python.org/review/27364/diff/17744/Objects/unicodeobject.c File Objects/unicodeobject.c (right): https://bugs.python.org/review/27364/diff/17744/Objects/unicodeobject.c#newcode6026 Objects/unicodeobject.c:6026: PyErr_WarnFormat(PyExc_DeprecationWarning, 1, See the documentation <https://docs.python.org/3.6/c-api/exceptions.html#issuing-warnings>: This function returns ...
1 year, 5 months ago #4
Martin Panter
https://bugs.python.org/review/27364/diff/17748/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): https://bugs.python.org/review/27364/diff/17748/Lib/test/test_unicode.py#newcode2733 Lib/test/test_unicode.py:2733: for letter in "deghijklmopqswyzABCDEFGHIJKLMOPQRSTVWXYZ": Why not test lowercase "c"? ...
1 year, 5 months ago #5
Martin Panter
https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py File Lib/test/test_codecs.py (right): https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py#newcode1218 Lib/test/test_codecs.py:1218: decode(b"\\" + b) Can’t you keep calling check() to ...
1 year, 4 months ago #6
ebarry
https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py File Lib/test/test_codecs.py (right): https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py#newcode1218 Lib/test/test_codecs.py:1218: decode(b"\\" + b) On 2016/07/23 13:54:47, vadmium wrote: > ...
1 year, 4 months ago #7
Martin Panter
https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py File Lib/test/test_codecs.py (right): https://bugs.python.org/review/27364/diff/17904/Lib/test/test_codecs.py#newcode1218 Lib/test/test_codecs.py:1218: decode(b"\\" + b) On 2016/07/23 14:14:59, ebarry wrote: > ...
1 year, 4 months ago #8
Martin Panter
https://bugs.python.org/review/27364/diff/18135/Lib/test/support/__init__.py File Lib/test/support/__init__.py (right): https://bugs.python.org/review/27364/diff/18135/Lib/test/support/__init__.py#newcode2200 Lib/test/support/__init__.py:2200: m = re.match(r"2.6.(\d{1,2})", kernel_version) Separate bug, but the dots ...
1 year, 3 months ago #9
storchaka
https://bugs.python.org/review/27364/diff/18135/Tools/scripts/fixcid.py File Tools/scripts/fixcid.py (right): https://bugs.python.org/review/27364/diff/18135/Tools/scripts/fixcid.py#newcode197 Tools/scripts/fixcid.py:197: String = r'"\([^\n\\"]\|\\.\)*"' On 2016/09/04 05:28:38, vadmium wrote: > ...
1 year, 3 months ago #10
r.david.murray
Looks good to me. I notice that in the test_re file you changed some strings ...
1 year, 3 months ago #11
storchaka
http://bugs.python.org/review/27364/diff/18406/Lib/test/test_bytes.py File Lib/test/test_bytes.py (right): http://bugs.python.org/review/27364/diff/18406/Lib/test/test_bytes.py#newcode219 Lib/test/test_bytes.py:219: sample = "Hello world\n\u1234\u5678\u9abc\\def0\\def0" On 2016/09/08 05:33:35, r.david.murray wrote: ...
1 year, 3 months ago #12
ebarry
http://bugs.python.org/review/27364/diff/18406/Lib/test/test_bytes.py File Lib/test/test_bytes.py (right): http://bugs.python.org/review/27364/diff/18406/Lib/test/test_bytes.py#newcode219 Lib/test/test_bytes.py:219: sample = "Hello world\n\u1234\u5678\u9abc\\def0\\def0" On 2016/09/08 06:57:54, storchaka wrote: ...
1 year, 3 months ago #13
storchaka
LGTM except unexpected place for one test. http://bugs.python.org/review/27364/diff/18418/Lib/test/test_unicode.py File Lib/test/test_unicode.py (right): http://bugs.python.org/review/27364/diff/18418/Lib/test/test_unicode.py#newcode2756 Lib/test/test_unicode.py:2756: def test_invalid_sequences(self): ...
1 year, 3 months ago #14
storchaka
1 year, 3 months ago #15
LGTM except unexpected place for one test.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7