Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2252)

#27243: __aiter__ should return async iterator instead of awaitable

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by yselivanov
Modified:
1 year, 4 months ago
Reviewers:
ncoghlan
CC:
gvanrossum, brett.cannon, Nick Coghlan, larry, ned.deily, lukasz.langa, devnull_psf.upfronthosting.co.za, Martin Panter, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/glossary.rst View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
Doc/reference/compound_stmts.rst View 1 2 1 chunk +1 line, -1 line 0 comments Download
Doc/reference/datamodel.rst View 1 2 3 chunks +45 lines, -2 lines 1 comment Download
Include/genobject.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
Lib/_collections_abc.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
Lib/asyncio/compat.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Lib/asyncio/streams.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
Lib/test/test_coroutines.py View 1 2 8 chunks +78 lines, -20 lines 0 comments Download
Lib/test/test_grammar.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
Objects/genobject.c View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
Python/ceval.c View 1 2 3 chunks +38 lines, -2 lines 1 comment Download

Messages

Total messages: 2
Nick Coghlan
Basic mechanics of the patch look good to me, I'll put some general feedback on ...
1 year, 4 months ago #1
Nick Coghlan
1 year, 4 months ago #2
Just a couple of minor comments on docs/comments - the actual functional changes
look fine to me.

http://bugs.python.org/review/27243/diff/17579/Doc/reference/datamodel.rst
File Doc/reference/datamodel.rst (right):

http://bugs.python.org/review/27243/diff/17579/Doc/reference/datamodel.rst#ne...
Doc/reference/datamodel.rst:2367: .. note::
Minor note: this can be moved down to after the "versionadded" note, rather than
being ahead of the main async iterator documentation.

http://bugs.python.org/review/27243/diff/17579/Python/ceval.c
File Python/ceval.c (right):

http://bugs.python.org/review/27243/diff/17579/Python/ceval.c#newcode1966
Python/ceval.c:1966: resolve to asynchronous generators.)
Minor typo: last term should also be "asynchronous iterators"
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7