Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1153)

#27095: Simplify MAKE_FUNCTION

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by gunkmute
Modified:
1 year, 6 months ago
Reviewers:
storchaka+cpython
CC:
Mark.Shannon, devnull_psf.upfronthosting.co.za, storchaka, serprex
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 8

Patch Set 4 #

Total comments: 5

Patch Set 5 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/dis.rst View 1 2 3 4 2 chunks +8 lines, -20 lines 1 comment Download
Include/opcode.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
Lib/importlib/_bootstrap_external.py View 1 2 3 4 3 chunks +4 lines, -7 lines 0 comments Download
Lib/lib2to3/tests/data/py3_test_grammar.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
Lib/opcode.py View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
Lib/test/test_dis.py View 1 2 3 4 1 chunk +39 lines, -41 lines 0 comments Download
Lib/test/test_grammar.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
Objects/abstract.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
Python/ceval.c View 1 2 3 4 1 chunk +22 lines, -102 lines 0 comments Download
Python/compile.c View 1 2 3 4 12 chunks +141 lines, -116 lines 0 comments Download
Python/opcode_targets.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
storchaka
http://bugs.python.org/review/27095/diff/17332/Lib/lib2to3/tests/data/py3_test_grammar.py File Lib/lib2to3/tests/data/py3_test_grammar.py (right): http://bugs.python.org/review/27095/diff/17332/Lib/lib2to3/tests/data/py3_test_grammar.py#newcode322 Lib/lib2to3/tests/data/py3_test_grammar.py:322: # test MAKE_FUNCTION with a variety of oparg's Tests ...
1 year, 6 months ago #1
storchaka
https://bugs.python.org/review/27095/diff/17616/Python/compile.c File Python/compile.c (right): https://bugs.python.org/review/27095/diff/17616/Python/compile.c#newcode1586 Python/compile.c:1586: if (keys != NULL) { Just Py_XDECREF(keys). https://bugs.python.org/review/27095/diff/17616/Python/compile.c#newcode1594 Python/compile.c:1594: ...
1 year, 6 months ago #2
storchaka
1 year, 6 months ago #3
http://bugs.python.org/review/27095/diff/17621/Doc/library/dis.rst
File Doc/library/dis.rst (right):

http://bugs.python.org/review/27095/diff/17621/Doc/library/dis.rst#newcode961
Doc/library/dis.rst:961: EXTENDED_ARG adds ``*ext* * 256`` to the next
instruction's argument.
I would prefer to commit this in issue26647 together with other doc changes.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7