Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(145)

#27078: Make f'' strings faster than .format: BUILD_STRING opcode?

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by antti
Modified:
1 year, 3 months ago
Reviewers:
gunkmute, storchaka+cpython, eric
CC:
rhettinger, mjpieters, eric.smith, devnull_psf.upfronthosting.co.za, storchaka, ztane, serprex
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/dis.rst View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
Include/opcode.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Include/unicodeobject.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
Lib/importlib/_bootstrap_external.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
Lib/opcode.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Objects/abstract.c View 1 2 3 1 chunk +19 lines, -1 line 0 comments Download
Objects/unicodeobject.c View 1 2 3 3 chunks +25 lines, -19 lines 0 comments Download
PC/launcher.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
Python/ceval.c View 1 2 3 1 chunk +18 lines, -0 lines 1 comment Download
Python/compile.c View 1 2 3 2 chunks +2 lines, -24 lines 0 comments Download
Python/importlib.h View 1 2 3 1 chunk +204 lines, -205 lines 0 comments Download
Python/importlib_external.h View 1 2 3 98 chunks +104 lines, -104 lines 0 comments Download
Python/opcode_targets.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
serprex
http://bugs.python.org/review/27078/diff/17857/Python/ceval.c File Python/ceval.c (right): http://bugs.python.org/review/27078/diff/17857/Python/ceval.c#newcode2533 Python/ceval.c:2533: TARGET(BUILD_STRING) { This could remove FORMAT_VALUE by having it ...
1 year, 4 months ago #1
storchaka
http://bugs.python.org/review/27078/diff/17857/Python/ceval.c File Python/ceval.c (right): http://bugs.python.org/review/27078/diff/17857/Python/ceval.c#newcode2533 Python/ceval.c:2533: TARGET(BUILD_STRING) { On 2016/07/14 20:26:04, serprex wrote: > This ...
1 year, 4 months ago #2
ztane
http://bugs.python.org/review/27078/diff/17857/Python/ceval.c File Python/ceval.c (right): http://bugs.python.org/review/27078/diff/17857/Python/ceval.c#newcode2533 Python/ceval.c:2533: TARGET(BUILD_STRING) { On 2016/07/14 21:38:29, storchaka wrote: > On ...
1 year, 4 months ago #3
eric.smith
1 year, 3 months ago #4
One small comment about a possible tiny further optimization. Otherwise, looks
good to me.

http://bugs.python.org/review/27078/diff/17878/Python/ceval.c
File Python/ceval.c (right):

http://bugs.python.org/review/27078/diff/17878/Python/ceval.c#newcode2535
Python/ceval.c:2535: PyObject *empty = PyUnicode_New(0, 0);
Is there a way to expose unicode_empty from unicodeobject.c, instead of
allocating a new one every time through? I'm not sure it makes enough of a
difference, though. Or, have _PyUnicode_JoinArray assume that a first param of
NULL means the empty string, and have it use unicode_empty.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7