Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69822)

#27029: Remove support of deprecated mode 'U' in zipfile

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by storchaka+cpython
Modified:
3 years, 5 months ago
Reviewers:
jimjjewett
CC:
Thomas Wouters, alanmcintyre, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/zipfile.rst View 1 3 chunks +8 lines, -13 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 1 chunk +5 lines, -0 lines 0 comments Download
Lib/test/test_zipfile.py View 1 4 chunks +4 lines, -163 lines 0 comments Download
Lib/zipfile.py View 1 5 chunks +4 lines, -46 lines 0 comments Download

Messages

Total messages: 2
Jim.J.Jewett
http://bugs.python.org/review/27029/diff/17248/Doc/library/zipfile.rst File Doc/library/zipfile.rst (right): http://bugs.python.org/review/27029/diff/17248/Doc/library/zipfile.rst#newcode210 Doc/library/zipfile.rst:210: is the name of the file in the archive, ...
3 years, 5 months ago #1
storchaka
3 years, 5 months ago #2
http://bugs.python.org/review/27029/diff/17248/Doc/library/zipfile.rst
File Doc/library/zipfile.rst (right):

http://bugs.python.org/review/27029/diff/17248/Doc/library/zipfile.rst#newcod...
Doc/library/zipfile.rst:210: is the name of the file in the archive, or a
:class:`ZipInfo` object.  The
On 2016/05/23 16:08:12, Jim.J.Jewett wrote:
> If name the file in both cases, or can it refer to the Zipinfo object?  If it
> always refers to the file, please reword that something like
> 
> "*name* is the name of the file in either the archive or a :class:`ZipInfo`
> object.
> 
> If it name can be the ZipInfo object itself, then please reword something
like:
> 
> "*name* can be either a :class:`ZipInfo` object or the name of a file within
the
> archive."

The latter. Thank you for your suggestion.

http://bugs.python.org/review/27029/diff/17248/Doc/library/zipfile.rst#newcod...
Doc/library/zipfile.rst:247: Removed support of ``mode='U'``.
On 2016/05/23 16:08:12, Jim.J.Jewett wrote:
> I would leave in the workaround information about using
> :class:`io.TextIOWrapper`.  Maybe even show it as an example that does get
> tested; something like:
> 
> f=io.TextIOWrapper(myarchive.open("myfile"))
> 
> except that I am not at all confident I have the syntax right -- which is why
it
> is worth documenting.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+