Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

#26915: Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by angwerzx
Modified:
3 years, 7 months ago
Reviewers:
storchaka+cpython
CC:
rhettinger, stutzbach, devnull_psf.upfronthosting.co.za, storchaka, Josh.R, xiang.zhang
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Patch Set 5 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/_collections_abc.py View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
Lib/test/test_collections.py View 1 2 3 4 1 chunk +14 lines, -4 lines 1 comment Download

Messages

Total messages: 2
storchaka
http://bugs.python.org/review/26915/diff/17163/Lib/test/test_collections.py File Lib/test/test_collections.py (right): http://bugs.python.org/review/26915/diff/17163/Lib/test/test_collections.py#newcode1093 Lib/test/test_collections.py:1093: containers = [seq, ItemsView({1: nan, 2: obj}), ValuesView({1: nan, ...
3 years, 7 months ago #1
storchaka
3 years, 7 months ago #2
http://bugs.python.org/review/26915/diff/17491/Lib/test/test_collections.py
File Lib/test/test_collections.py (right):

http://bugs.python.org/review/26915/diff/17491/Lib/test/test_collections.py#n...
Lib/test/test_collections.py:1102: self.assertNotEqual(seq.index(nan), 1)
What the purpose of this test?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+