Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2251)

#26870: Unexpected call to readline's add_history in call_readline

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by tyler
Modified:
1 year, 5 months ago
Reviewers:
vadmium+py
CC:
Thomas Wouters, meadori, devnull_psf.upfronthosting.co.za, Martin Panter, tyler_tylercrompton.com
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/readline.rst View 1 1 chunk +14 lines, -0 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download
Lib/test/test_readline.py View 1 2 chunks +49 lines, -0 lines 0 comments Download
Misc/ACKS View 1 1 chunk +1 line, -0 lines 0 comments Download
Misc/NEWS View 1 1 chunk +4 lines, -0 lines 0 comments Download
Modules/readline.c View 1 3 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 2
Martin Panter
https://bugs.python.org/review/26870/diff/17175/Doc/library/readline.rst File Doc/library/readline.rst (right): https://bugs.python.org/review/26870/diff/17175/Doc/library/readline.rst#newcode162 Doc/library/readline.rst:162: input via readline. *enabled* should be a Boolean value ...
1 year, 5 months ago #1
Martin Panter
1 year, 5 months ago #2
https://bugs.python.org/review/26870/diff/17175/Doc/library/readline.rst
File Doc/library/readline.rst (right):

https://bugs.python.org/review/26870/diff/17175/Doc/library/readline.rst#newc...
Doc/library/readline.rst:162: input via readline. *enabled* should be a Boolean
value that when True,
On 2016/05/08 09:50:10, vadmium wrote:
> I prefer to start a sentence with a capital letter. You could rewrite this as
> “The *enabled* argument should . . .”.

Done.

https://bugs.python.org/review/26870/diff/17175/Modules/readline.c
File Modules/readline.c (right):

https://bugs.python.org/review/26870/diff/17175/Modules/readline.c#newcode1301
Modules/readline.c:1301: if (should_auto_add_history && strcmp(p, line))
On 2016/05/08 09:50:10, vadmium wrote:
> I think you could move this check to the outer if (n > 0) check, no?

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7