Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

#26826: Expose new copy_file_range() syscal in os module and use it to improve shutils.copy()

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by mdione
Modified:
3 years, 7 months ago
Reviewers:
vadmium+py, facundo
CC:
facundobatista, Nick Coghlan, haypo, giampaolo.rodola, StyXman, encukou, Charles-François Natali, Martin Panter, desbma, pablogsal
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 1

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 11

Patch Set 7 #

Patch Set 8 #

Total comments: 4

Patch Set 9 #

Patch Set 10 #

Total comments: 3

Patch Set 11 #

Patch Set 12 #

Total comments: 2

Patch Set 13 #

Patch Set 14 #

Patch Set 15 #

Total comments: 2

Patch Set 16 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
configure.ac View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -0 lines 0 comments Download
Doc/library/os.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +21 lines, -0 lines 0 comments Download
Lib/test/test_os.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +77 lines, -0 lines 0 comments Download
Modules/posixmodule.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +78 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Martin Panter
https://bugs.python.org/review/26826/diff/17083/Doc/library/os.rst File Doc/library/os.rst (right): https://bugs.python.org/review/26826/diff/17083/Doc/library/os.rst#newcode682 Doc/library/os.rst:682: provided to allow for future extensions and currently must ...
3 years, 10 months ago #1
Martin Panter
https://bugs.python.org/review/26826/diff/17101/Doc/library/os.rst File Doc/library/os.rst (right): https://bugs.python.org/review/26826/diff/17101/Doc/library/os.rst#newcode679 Doc/library/os.rst:679: respectively for *offset_out*. *in* and *out* must reside in ...
3 years, 10 months ago #2
Martin Panter
http://bugs.python.org/review/26826/diff/17101/Modules/posixmodule.c File Modules/posixmodule.c (right): http://bugs.python.org/review/26826/diff/17101/Modules/posixmodule.c#newcode8414 Modules/posixmodule.c:8414: "copy_file_range(in, offset_in, out, offset_out, count, flags=0) -> \ Current ...
3 years, 9 months ago #3
Martin Panter
http://bugs.python.org/review/26826/diff/17142/Doc/library/os.rst File Doc/library/os.rst (right): http://bugs.python.org/review/26826/diff/17142/Doc/library/os.rst#newcode687 Doc/library/os.rst:687: The flags argument is provided to allow for future ...
3 years, 9 months ago #4
StyXman
Sorry, I didn't know I should publish the drafts (or that they were drafts). https://bugs.python.org/review/26826/diff/17101/Doc/library/os.rst ...
3 years, 9 months ago #5
Martin Panter
https://bugs.python.org/review/26826/diff/17101/Modules/posixmodule.c File Modules/posixmodule.c (right): https://bugs.python.org/review/26826/diff/17101/Modules/posixmodule.c#newcode8434 Modules/posixmodule.c:8434: if (!PyArg_ParseTupleAndKeywords(args, kwdict, "iOiOn|i:copy_file_range", On 2016/05/12 12:51:46, StyXman wrote: ...
3 years, 9 months ago #6
Martin Panter
https://bugs.python.org/review/26826/diff/17581/Doc/library/os.rst File Doc/library/os.rst (right): https://bugs.python.org/review/26826/diff/17581/Doc/library/os.rst#newcode686 Doc/library/os.rst:686: *offset_src*, to file descriptor *dst*, starting from offset *offset_dst*. ...
3 years, 8 months ago #7
facundobatista
https://bugs.python.org/review/26826/diff/17587/Doc/library/os.rst File Doc/library/os.rst (right): https://bugs.python.org/review/26826/diff/17587/Doc/library/os.rst#newcode698 Doc/library/os.rst:698: currently can only be 0. You say that the ...
3 years, 7 months ago #8
Martin Panter
3 years, 7 months ago #9
https://bugs.python.org/review/26826/diff/17806/Lib/test/test_os.py
File Lib/test/test_os.py (right):

https://bugs.python.org/review/26826/diff/17806/Lib/test/test_os.py#newcode259
Lib/test/test_os.py:259: out_file = open (TESTFN2, 'w+b')
Extra space in function call not needed

https://bugs.python.org/review/26826/diff/17806/Lib/test/test_os.py#newcode265
Lib/test/test_os.py:265: i = os.copy_file_range(in_fd, out_fd, 5);
Extra semicolon not needed
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+