Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

#26798: add BLAKE2 to hashlib

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by zookog
Modified:
1 year, 3 months ago
Reviewers:
vadmium+py
CC:
gregory.p.smith, christian.heimes, alex, devnull_psf.upfronthosting.co.za, Martin Panter, dstufft, zookog_gmail.com, dmitry_codingrobots.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 4

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/crypto.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Doc/library/hashlib-blake2.rst View 1 2 3 4 1 chunk +443 lines, -0 lines 0 comments Download
Doc/library/hashlib.rst View 1 2 3 4 3 chunks +12 lines, -1 line 0 comments Download
Lib/hashlib.py View 1 2 3 4 5 chunks +22 lines, -10 lines 0 comments Download
Lib/test/test_hashlib.py View 1 2 3 4 9 chunks +195 lines, -6 lines 0 comments Download
Makefile.pre.in View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download
Modules/_blake2/blake2b2s.py View 1 2 3 4 1 chunk +49 lines, -0 lines 0 comments Download
Modules/_blake2/blake2b_impl.c View 1 2 3 4 1 chunk +460 lines, -0 lines 0 comments Download
Modules/_blake2/blake2module.c View 1 2 3 4 1 chunk +105 lines, -0 lines 0 comments Download
Modules/_blake2/blake2ns.h View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
Modules/_blake2/blake2s_impl.c View 1 2 3 4 1 chunk +460 lines, -0 lines 0 comments Download
Modules/_blake2/clinic/blake2b_impl.c.h View 1 2 3 4 1 chunk +125 lines, -0 lines 0 comments Download
Modules/_blake2/clinic/blake2s_impl.c.h View 1 2 3 4 1 chunk +125 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2-config.h View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2-impl.h View 1 2 3 4 1 chunk +139 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2.h View 1 2 3 4 1 chunk +161 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2b-load-sse2.h View 1 2 3 4 1 chunk +70 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2b-load-sse41.h View 1 2 3 4 1 chunk +404 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2b-ref.c View 1 2 3 4 1 chunk +416 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2b-round.h View 1 2 3 4 1 chunk +159 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2b.c View 1 2 3 4 1 chunk +450 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s-load-sse2.h View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s-load-sse41.h View 1 2 3 4 1 chunk +231 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s-load-xop.h View 1 2 3 4 1 chunk +191 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s-ref.c View 1 2 3 4 1 chunk +406 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s-round.h View 1 2 3 4 1 chunk +90 lines, -0 lines 0 comments Download
Modules/_blake2/impl/blake2s.c View 1 2 3 4 1 chunk +431 lines, -0 lines 0 comments Download
Modules/hashlib.h View 1 2 3 4 1 chunk +11 lines, -8 lines 0 comments Download
PCbuild/pythoncore.vcxproj View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
PCbuild/pythoncore.vcxproj.filters View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Martin Panter
1 year, 3 months ago #1
https://bugs.python.org/review/26798/diff/18192/Doc/library/hashlib.blake2.rst
File Doc/library/hashlib.blake2.rst (right):

https://bugs.python.org/review/26798/diff/18192/Doc/library/hashlib.blake2.rs...
Doc/library/hashlib.blake2.rst:48: * `data`: initial chunk of data to hash,
which must be interpretable as buffer
The main hashlib.rst file uses *data* markup for parameter names. Anyway I think
single back-ticks produce warnings when you build the documentation.

https://bugs.python.org/review/26798/diff/18192/Doc/library/hashlib.blake2.rs...
Doc/library/hashlib.blake2.rst:255: >>> m = hmac.new(b'secret key',
digestmod=pyblake2.blake2s)
I guess you copied this from the external module, so “pyblake2” probably needs
changing

https://bugs.python.org/review/26798/diff/18192/Doc/library/hashlib.rst
File Doc/library/hashlib.rst (right):

https://bugs.python.org/review/26798/diff/18192/Doc/library/hashlib.rst#newco...
Doc/library/hashlib.rst:15: single: blake2b, blake2s
Wouldn’t it be better to move these to the other file?

https://bugs.python.org/review/26798/diff/18192/Lib/hashlib.py
File Lib/hashlib.py (right):

https://bugs.python.org/review/26798/diff/18192/Lib/hashlib.py#newcode17
Lib/hashlib.py:17: all 64bit platforms), blake2b and blake2s are supported.
Is this out of date regarding 32-bit platforms?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7