Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

#26588: _tracemalloc: add support for multiple address spaces (domains)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by victor.stinner
Modified:
1 year, 7 months ago
Reviewers:
pitrou
CC:
AntoinePitrou, haypo, njs, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 10

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/_tracemalloc.c View 1 2 3 4 5 14 chunks +68 lines, -37 lines 0 comments Download
Modules/hashtable.c View 1 2 3 4 5 21 chunks +62 lines, -43 lines 0 comments Download
Modules/hashtable.h View 1 2 3 4 5 4 chunks +76 lines, -27 lines 2 comments Download
Python/marshal.c View 1 2 3 4 5 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4
AntoinePitrou
https://bugs.python.org/review/26588/diff/16783/Doc/library/tracemalloc.rst File Doc/library/tracemalloc.rst (right): https://bugs.python.org/review/26588/diff/16783/Doc/library/tracemalloc.rst#newcode328 Doc/library/tracemalloc.rst:328: Added *use_domain* parameter. What does it do? https://bugs.python.org/review/26588/diff/16783/Lib/test/test_tracemalloc.py File ...
1 year, 7 months ago #1
haypo
https://bugs.python.org/review/26588/diff/16783/Doc/library/tracemalloc.rst File Doc/library/tracemalloc.rst (right): https://bugs.python.org/review/26588/diff/16783/Doc/library/tracemalloc.rst#newcode328 Doc/library/tracemalloc.rst:328: Added *use_domain* parameter. On 2016/03/21 13:07:43, AntoinePitrou wrote: > ...
1 year, 7 months ago #2
AntoinePitrou
https://bugs.python.org/review/26588/diff/16803/Modules/hashtable.h File Modules/hashtable.h (right): https://bugs.python.org/review/26588/diff/16803/Modules/hashtable.h#newcode127 Modules/hashtable.h:127: size_t key_size, I'm curious: why pass the key size ...
1 year, 7 months ago #3
haypo
1 year, 7 months ago #4
https://bugs.python.org/review/26588/diff/16803/Modules/hashtable.h
File Modules/hashtable.h (right):

https://bugs.python.org/review/26588/diff/16803/Modules/hashtable.h#newcode127
Modules/hashtable.h:127: size_t key_size,
On 2016/03/21 20:15:57, AntoinePitrou wrote:
> I'm curious: why pass the key size if key_size is already a member of the hash
> table?

The purpose is the same of data_size parameter in _Py_hashtable_get(): help to
detect bugs in the user of the API using assertions in debug mode. For example,
if you change the key size or data size of an hashtable, these checks ensure
that functions like "compare" and "hash" are also updated.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7