Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

#26574: replace_interleave can be optimized for single character byte strings

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by josh
Modified:
1 year, 9 months ago
Reviewers:
victor.stinner
CC:
haypo, devnull_psf.upfronthosting.co.za, storchaka, Josh Snider
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Misc/ACKS View 1 1 chunk +1 line, -0 lines 0 comments Download
Objects/bytearrayobject.c View 1 1 chunk +19 lines, -9 lines 0 comments Download
Objects/bytesobject.c View 1 1 chunk +19 lines, -9 lines 0 comments Download

Messages

Total messages: 1
haypo
1 year, 9 months ago #1
https://bugs.python.org/review/26574/diff/16755/Objects/bytearrayobject.c
File Objects/bytearrayobject.c (left):

https://bugs.python.org/review/26574/diff/16755/Objects/bytearrayobject.c#old...
Objects/bytearrayobject.c:1720: 
Please keep these empty lines that help for readability.

https://bugs.python.org/review/26574/diff/16755/Objects/bytearrayobject.c
File Objects/bytearrayobject.c (right):

https://bugs.python.org/review/26574/diff/16755/Objects/bytearrayobject.c#new...
Objects/bytearrayobject.c:1719: 
I don't think that this newline is needed.

https://bugs.python.org/review/26574/diff/16755/Objects/bytearrayobject.c#new...
Objects/bytearrayobject.c:1720: } else {
PEP 7: need to rewrite this line as:

}
else {

https://bugs.python.org/review/26574/diff/16755/Objects/bytesobject.c
File Objects/bytesobject.c (right):

https://bugs.python.org/review/26574/diff/16755/Objects/bytesobject.c#newcode...
Objects/bytesobject.c:2478: } else {
same comments
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7