Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2212)

#26564: Malloc debug hooks: display memory block traceback on error

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by victor.stinner
Modified:
1 year, 7 months ago
Reviewers:
CC:
haypo, devnull_psf.upfronthosting.co.za, Martin Panter
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/traceback.h View 1 chunk +14 lines, -0 lines 0 comments Download
Modules/_tracemalloc.c View 1 chunk +56 lines, -0 lines 2 comments Download
Objects/obmalloc.c View 2 chunks +9 lines, -0 lines 0 comments Download
Parser/pgenmain.c View 1 chunk +4 lines, -3 lines 0 comments Download
Python/traceback.c View 4 chunks +7 lines, -16 lines 1 comment Download

Messages

Total messages: 1
haypo
1 year, 7 months ago #1
http://bugs.python.org/review/26564/diff/16745/Modules/_tracemalloc.c
File Modules/_tracemalloc.c (right):

http://bugs.python.org/review/26564/diff/16745/Modules/_tracemalloc.c#newcode...
Modules/_tracemalloc.c:1232: if (frame->filename != NULL) {
frame->filename cannot be NULL

http://bugs.python.org/review/26564/diff/16745/Modules/_tracemalloc.c#newcode...
Modules/_tracemalloc.c:1257: PUTS(fd, "Memory block traceback (most recent call
first):\n");
"Memory block allocated at (...):"

http://bugs.python.org/review/26564/diff/16745/Python/traceback.c
File Python/traceback.c (right):

http://bugs.python.org/review/26564/diff/16745/Python/traceback.c#newcode499
Python/traceback.c:499: char buffer[7];
Hum, the buffer can maybe be extended to support larger line numbers?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7