Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

#26470: Make OpenSSL module compatible with OpenSSL 1.1.0

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by lists
Modified:
1 year, 3 months ago
Reviewers:
stephane, victor.stinner
CC:
bill.janssen_gmail.com, AntoinePitrou, giampaolo.rodola, christian.heimes, alex, devnull_psf.upfronthosting.co.za, Zach Ware, dstufft, matrixise, python_bachfreund.nl, Michael.Felt, Chi Hsuan Yen, steven_pictortribus.co.uk
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 5

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 4

Patch Set 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 1 2 3 4 5 6 21 chunks +87 lines, -21 lines 0 comments Download
Lib/ssl.py View 1 2 3 4 5 6 8 chunks +10 lines, -8 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 5 6 10 chunks +58 lines, -31 lines 0 comments Download
Modules/_hashopenssl.c View 1 2 3 4 5 6 17 chunks +106 lines, -59 lines 0 comments Download

Messages

Total messages: 2
matrixise
just for the code, ok for the functionality, I am not an expert of LibreSSL/OpenSSL, ...
1 year, 4 months ago #1
haypo
1 year, 3 months ago #2
LGTM but I added a few minor comments.

http://bugs.python.org/review/26470/diff/18286/Doc/library/ssl.rst
File Doc/library/ssl.rst (right):

http://bugs.python.org/review/26470/diff/18286/Doc/library/ssl.rst#newcode324
Doc/library/ssl.rst:324: .. deprecated::
Hum, 3.6 should be written on this line, no?

http://bugs.python.org/review/26470/diff/18286/Doc/library/ssl.rst#newcode595
Doc/library/ssl.rst:595: .. deprecated:: 3.6 Use  ``PROTOCOL_TLS`` instead.
I'm not sure that the doc is rendered correctly, the text should be written in a
new block, no?

http://bugs.python.org/review/26470/diff/18286/Modules/_hashopenssl.c
File Modules/_hashopenssl.c (right):

http://bugs.python.org/review/26470/diff/18286/Modules/_hashopenssl.c#newcode107
Modules/_hashopenssl.c:107: return NULL;
PEP 7: should be written

 if (retval == NULL) {
     return NULL;
 }

http://bugs.python.org/review/26470/diff/18286/Modules/_hashopenssl.c#newcode160
Modules/_hashopenssl.c:160: /* XXX no error reporting */
I don't understand the comment. Is it a bug report for OpenSSL?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7