Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(106)

#26415: Fragmentation of the heap memory in the Python parser

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by tyomitch
Modified:
2 years, 6 months ago
Reviewers:
jimjjewett, brett, xavier.combelle
CC:
fdrake_gmail.com, rhettinger, pmoore, haypo, christian.heimes, tim.golden, Benjamin Peterson, encukou, berkerpeksag, Zach Ware, storchaka, eryksun, steve.dower, xcombelle, A. Skrobov, cstratak, pablogsal
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 12

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/node.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Misc/NEWS View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
Modules/parsermodule.c View 1 2 3 7 chunks +175 lines, -8 lines 0 comments Download
Parser/parser.c View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
Parser/pgenmain.c View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
Python/ast.c View 1 2 3 25 chunks +183 lines, -161 lines 0 comments Download
setup.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
Jim.J.Jewett
Some of my comments are from the order I read it, and some just because ...
2 years, 8 months ago #1
A. Skrobov
Thank you for the review! http://bugs.python.org/review/26415/diff/17548/Python/ast.c File Python/ast.c (right): http://bugs.python.org/review/26415/diff/17548/Python/ast.c#newcode5050 Python/ast.c:5050: void PyNode_Compress(node* n) { ...
2 years, 8 months ago #2
brett.cannon
On 2016/07/08 18:25:55, A. Skrobov wrote: > Thank you for the review! > > http://bugs.python.org/review/26415/diff/17548/Python/ast.c ...
2 years, 8 months ago #3
xcombelle
http://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c File Modules/parsermodule.c (right): http://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c#newcode769 Modules/parsermodule.c:769: this function is long, it would be nice if ...
2 years, 7 months ago #4
A. Skrobov
http://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c File Modules/parsermodule.c (right): http://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c#newcode769 Modules/parsermodule.c:769: First of all, it's a private function in a ...
2 years, 7 months ago #5
Jim.J.Jewett
https://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c File Modules/parsermodule.c (right): https://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c#newcode769 Modules/parsermodule.c:769: On 2016/08/23 14:39:23, A. Skrobov wrote: > First of ...
2 years, 6 months ago #6
A. Skrobov
2 years, 6 months ago #7
https://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c
File Modules/parsermodule.c (right):

https://bugs.python.org/review/26415/diff/17823/Modules/parsermodule.c#newcod...
Modules/parsermodule.c:769: 
On 2016/08/29 21:23:42, Jim.J.Jewett wrote:

> Adding that explanation to a code comment would be great.

That's a good point! I've updated the patch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+