Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

#26404: socketserver context manager

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by palaviv
Modified:
1 year, 8 months ago
Reviewers:
vadmium+py, berker.peksag
CC:
terry.reedy, devnull_psf.upfronthosting.co.za, Martin Panter, palaviv
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 12

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.server.rst View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
Doc/library/socketserver.rst View 1 2 3 5 chunks +27 lines, -23 lines 2 comments Download
Doc/library/wsgiref.rst View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
Doc/library/xmlrpc.server.rst View 1 2 3 2 chunks +29 lines, -30 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 3 1 chunk +10 lines, -0 lines 2 comments Download
Lib/http/server.py View 1 2 3 1 chunk +8 lines, -10 lines 0 comments Download
Lib/socketserver.py View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
Lib/test/test_socketserver.py View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
Lib/wsgiref/simple_server.py View 1 2 3 1 chunk +6 lines, -7 lines 0 comments Download
Lib/xmlrpc/server.py View 1 2 3 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 6
Martin Panter
https://bugs.python.org/review/26404/diff/16630/Doc/library/socketserver.rst File Doc/library/socketserver.rst (right): https://bugs.python.org/review/26404/diff/16630/Doc/library/socketserver.rst#newcode60 Doc/library/socketserver.rst:60: to close the socket ( Unless you used the ...
1 year, 9 months ago #1
Martin Panter
https://bugs.python.org/review/26404/diff/16642/Doc/library/socketserver.rst File Doc/library/socketserver.rst (right): https://bugs.python.org/review/26404/diff/16642/Doc/library/socketserver.rst#newcode56 Doc/library/socketserver.rst:56: the class using :keyword:`with` statement. Then call the “Initiate” ...
1 year, 9 months ago #2
palaviv
CR reply http://bugs.python.org/review/26404/diff/16642/Doc/library/socketserver.rst File Doc/library/socketserver.rst (right): http://bugs.python.org/review/26404/diff/16642/Doc/library/socketserver.rst#newcode56 Doc/library/socketserver.rst:56: the class using :keyword:`with` statement. Then call ...
1 year, 9 months ago #3
berkerpeksag
http://bugs.python.org/review/26404/diff/16646/Doc/library/socketserver.rst File Doc/library/socketserver.rst (right): http://bugs.python.org/review/26404/diff/16646/Doc/library/socketserver.rst#newcode357 Doc/library/socketserver.rst:357: .. versionadded:: 3.6 versionchanged This is an extension to ...
1 year, 9 months ago #4
palaviv
http://bugs.python.org/review/26404/diff/16646/Doc/library/socketserver.rst File Doc/library/socketserver.rst (right): http://bugs.python.org/review/26404/diff/16646/Doc/library/socketserver.rst#newcode357 Doc/library/socketserver.rst:357: .. versionadded:: 3.6 On 2016/02/24 14:09:38, berkerpeksag wrote: > ...
1 year, 9 months ago #5
Martin Panter
1 year, 8 months ago #6
http://bugs.python.org/review/26404/diff/16655/Doc/library/socketserver.rst
File Doc/library/socketserver.rst (right):

http://bugs.python.org/review/26404/diff/16655/Doc/library/socketserver.rst#n...
Doc/library/socketserver.rst:60: to close the socket (unless you used the
:keyword:`with` statement).
a “with” statement (matching ‘in a “with” statement’ above)

http://bugs.python.org/review/26404/diff/16655/Doc/library/socketserver.rst#n...
Doc/library/socketserver.rst:599: with ThreadedTCPServer((HOST, PORT),
ThreadedTCPRequestHandler) as server:
Split this into two lines to limit the width

http://bugs.python.org/review/26404/diff/16655/Doc/whatsnew/3.6.rst
File Doc/whatsnew/3.6.rst (right):

http://bugs.python.org/review/26404/diff/16655/Doc/whatsnew/3.6.rst#newcode190
Doc/whatsnew/3.6.rst:190: ----
Needed more underlines to stop a doc build warning. Also I moved this section up
into alphabetical order.

http://bugs.python.org/review/26404/diff/16655/Doc/whatsnew/3.6.rst#newcode194
Doc/whatsnew/3.6.rst:194: :mod:`wsgiref.simple_server`, supports the
:term:`context manager`
Servers . . . now support . . . (no S at the end)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7