Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43535)

#26305: Make Argument Clinic to generate PEP 7 conforming code

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by storchaka+cpython
Modified:
3 years, 4 months ago
Reviewers:
vadmium+py
CC:
brett.cannon, larry, meadori, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/cmathmodule.c View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
Tools/clinic/clinic.py View 1 2 7 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 2
Martin Panter
http://bugs.python.org/review/26305/diff/16522/Tools/clinic/clinic.py File Tools/clinic/clinic.py (right): http://bugs.python.org/review/26305/diff/16522/Tools/clinic/clinic.py#newcode2969 Tools/clinic/clinic.py:2969: data.return_conversion.append('if (({}) && PyErr_Occurred()) {{{{\n goto exit;/*2*/\n}}}}\n'.format(expr)) Is the ...
3 years, 7 months ago #1
storchaka_gmail.com
3 years, 7 months ago #2
http://bugs.python.org/review/26305/diff/16522/Tools/clinic/clinic.py
File Tools/clinic/clinic.py (right):

http://bugs.python.org/review/26305/diff/16522/Tools/clinic/clinic.py#newcode...
Tools/clinic/clinic.py:2969: data.return_conversion.append('if (({}) &&
PyErr_Occurred()) {{{{\n    goto exit;/*2*/\n}}}}\n'.format(expr))
On 2016/02/08 12:32:23, vadmium wrote:
> Is the /*2*/ an accident?

Yes, of course. Thank you for catching this.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+