Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(721)

#26282: Add support for partial keyword arguments in extension functions

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by storchaka+cpython
Modified:
1 year, 7 months ago
Reviewers:
vadmium+py
CC:
rhettinger, larry, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Total comments: 1

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/arg.rst View 1 2 3 1 chunk +9 lines, -2 lines 0 comments Download
Doc/glossary.rst View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
Lib/test/test_capi.py View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
Lib/test/test_getargs2.py View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
Misc/NEWS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
Modules/_testcapimodule.c View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
Python/getargs.c View 1 2 3 6 chunks +81 lines, -44 lines 0 comments Download
Tools/clinic/clinic.py View 1 2 3 10 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 4
Martin Panter
https://bugs.python.org/review/26282/diff/16537/Lib/test/test_capi.py File Lib/test/test_capi.py (right): https://bugs.python.org/review/26282/diff/16537/Lib/test/test_capi.py#newcode525 Lib/test/test_capi.py:525: #_testcapi.parse_tuple_and_keywords((1, 2), {}, b'OO', ['', 'a']) Most of these ...
1 year, 10 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/26282/diff/16537/Lib/test/test_capi.py File Lib/test/test_capi.py (right): https://bugs.python.org/review/26282/diff/16537/Lib/test/test_capi.py#newcode588 Lib/test/test_capi.py:588: def test_positional_only(self): On 2016/02/10 06:21:37, vadmium wrote: > The ...
1 year, 10 months ago #2
Martin Panter
http://bugs.python.org/review/26282/diff/17128/Doc/c-api/arg.rst File Doc/c-api/arg.rst (right): http://bugs.python.org/review/26282/diff/17128/Doc/c-api/arg.rst#newcode409 Doc/c-api/arg.rst:409: parameters into local variables. *keywords* is a NULL-terminated array ...
1 year, 7 months ago #3
storchaka_gmail.com
1 year, 7 months ago #4
Thank you Martin for your suggestions!

http://bugs.python.org/review/26282/diff/17128/Doc/c-api/arg.rst
File Doc/c-api/arg.rst (right):

http://bugs.python.org/review/26282/diff/17128/Doc/c-api/arg.rst#newcode409
Doc/c-api/arg.rst:409: parameters into local variables.  *keywords* is a
NULL-terminated array of
On 2016/05/08 11:33:40, vadmium wrote:
> Maybe “The *keywords* argument is . . .”, to start the sentence with a Capital
> Letter.

Done.

http://bugs.python.org/review/26282/diff/17128/Doc/c-api/arg.rst#newcode410
Doc/c-api/arg.rst:410: keyword parameter names.  Empty name denotes
positional-only parameter.
On 2016/05/08 11:33:40, vadmium wrote:
> Empty [names denote] positional-only [parameters].

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7