Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

#26228: pty.spawn hangs on FreeBSD 9.3, 10.x

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by chris.torek
Modified:
4 years ago
Reviewers:
vadmium+py
CC:
haypo, Martin Panter, jbeck, earthlingzephyr_gmail.com, chris.torek_gmail.com, Cornelius Diekmann, jarryshaw_icloud.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/pty.py View 3 chunks +14 lines, -2 lines 0 comments Download
Lib/test/test_pty.py View 2 chunks +2 lines, -3 lines 1 comment Download

Messages

Total messages: 1
Martin Panter
4 years ago #1
https://bugs.python.org/review/26228/diff/16442/Lib/test/test_pty.py
File Lib/test/test_pty.py (right):

https://bugs.python.org/review/26228/diff/16442/Lib/test/test_pty.py#newcode288
Lib/test/test_pty.py:288: # We expect that both fds were removed from the fds
list as they
With your new implementation, I think this comment and append(0) is out of date.
Now we expect that _copy() see the master EOF and returns without calling
select() a second time.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+