Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

#26198: PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by hniksic
Modified:
4 years ago
Reviewers:
vadmium+py, storchaka
CC:
hniksic, docs_python.org, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, barun.parruck_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_capi.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
Lib/test/test_getargs2.py View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
Python/getargs.c View 1 2 9 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 2
Martin Panter
https://bugs.python.org/review/26198/diff/16428/Python/getargs.c File Python/getargs.c (right): https://bugs.python.org/review/26198/diff/16428/Python/getargs.c#newcode546 Python/getargs.c:546: strncpy(msgbuf, expected, bufsize); The strncpy() makes snprintf() redundant, doesn’t ...
4 years ago #1
storchaka_gmail.com
4 years ago #2
https://bugs.python.org/review/26198/diff/16428/Python/getargs.c
File Python/getargs.c (right):

https://bugs.python.org/review/26198/diff/16428/Python/getargs.c#newcode546
Python/getargs.c:546: strncpy(msgbuf, expected, bufsize);
On 2016/01/28 22:40:53, vadmium wrote:
> The strncpy() makes snprintf() redundant, doesn’t it?

Oh, true.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+