Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(333)

#26129: Difference in behaviour with grp.getgrgid and pwd.getpwuid

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by simonfr
Modified:
1 year, 11 months ago
Reviewers:
brett, storchaka
CC:
brett.cannon, larry, SilentGhost, devnull_psf.upfronthosting.co.za, storchaka, simonfr_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/grp.rst View 1 chunk +3 lines, -0 lines 0 comments Download
Lib/test/test_grp.py View 1 chunk +10 lines, -0 lines 0 comments Download
Modules/grpmodule.c View 1 chunk +14 lines, -5 lines 3 comments Download

Messages

Total messages: 2
brett.cannon
LGTM except for two style issues. http://bugs.python.org/review/26129/diff/16369/Modules/grpmodule.c File Modules/grpmodule.c (right): http://bugs.python.org/review/26129/diff/16369/Modules/grpmodule.c#newcode104 Modules/grpmodule.c:104: if (!PyErr_ExceptionMatches(PyExc_TypeError)) Missing ...
1 year, 11 months ago #1
storchaka_gmail.com
1 year, 11 months ago #2
http://bugs.python.org/review/26129/diff/16369/Modules/grpmodule.c
File Modules/grpmodule.c (right):

http://bugs.python.org/review/26129/diff/16369/Modules/grpmodule.c#newcode104
Modules/grpmodule.c:104: if (!PyErr_ExceptionMatches(PyExc_TypeError))
On 2016/01/17 18:55:15, brett.cannon wrote:
> Missing curly braces for `if` body.

Braces are not mandatory and often are omitted (especially for simple return
statement). And PEP 7 allows this style: "braces may be omitted where C
permits".

If you think the code would look better with braces I'll add them.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7