Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1018)

#26081: Implement asyncio Future in C to improve performance

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by yselivanov
Modified:
1 year ago
Reviewers:
storchaka+cpython, songofacandy
CC:
gvanrossum, haypo, giampaolo.rodola, ned.deily, inada.naoki, devnull_psf.upfronthosting.co.za, storchaka, Yury Selivanov, mpaolini, remi2402_free.fr
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 6

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 3

Patch Set 7 #

Patch Set 8 #

Patch Set 9 #

Patch Set 10 #

Patch Set 11 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/asyncio/futures.py View 1 2 3 4 5 6 7 8 9 10 3 chunks +57 lines, -37 lines 0 comments Download
Modules/Setup.dist View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
Modules/_futuresmodule.c View 1 2 3 4 5 6 7 8 9 10 1 chunk +1009 lines, -0 lines 0 comments Download
PCbuild/pythoncore.vcxproj View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
PCbuild/pythoncore.vcxproj.filters View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
setup.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Yury Selivanov
http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c File Modules/_futuresmodule.c (right): http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c#newcode410 Modules/_futuresmodule.c:410: return (PyObject *)fut; I remember now -- we should ...
1 year, 2 months ago #1
storchaka
http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c File Modules/_futuresmodule.c (right): http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c#newcode584 Modules/_futuresmodule.c:584: if (PyObject_IsTrue(val)) { PyObject_IsTrue() can fail (return -1). But ...
1 year, 2 months ago #2
inada.naoki
http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c File Modules/_futuresmodule.c (right): http://bugs.python.org/review/26081/diff/17828/Modules/_futuresmodule.c#newcode410 Modules/_futuresmodule.c:410: return (PyObject *)fut; On 2016/08/09 15:32:14, Yury Selivanov wrote: ...
1 year, 2 months ago #3
Yury Selivanov
1 year, 1 month ago #4
http://bugs.python.org/review/26081/diff/18483/Modules/_futuresmodule.c
File Modules/_futuresmodule.c (right):

http://bugs.python.org/review/26081/diff/18483/Modules/_futuresmodule.c#newco...
Modules/_futuresmodule.c:174: st = _FuturesMod_EnsureState();
Since we don't support sub interpreters, I think we don't really want to use the
"PyState_FindModule(&_futuresmodule);" machinery.  I'd simply use a static
variable.

http://bugs.python.org/review/26081/diff/18483/Modules/_futuresmodule.c#newco...
Modules/_futuresmodule.c:777: return FutureIter_iternext(self);
We should raise if anything except None is sent.

http://bugs.python.org/review/26081/diff/18483/Modules/_futuresmodule.c#newco...
Modules/_futuresmodule.c:862: future_iter(PyObject *fut)
Rename to "new_future_iter"
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7