Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1980)

#25928: Add Decimal.as_integer_ratio()

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by publicjohnwalker
Modified:
1 year, 9 months ago
Reviewers:
storchaka, stefan
CC:
gvanrossum, tim.peters, rhettinger, terry.reedy, mark.dickinson, sasha, stevenjd, skrah, devnull_psf.upfronthosting.co.za, storchaka, johnwalker
Visibility:
Public.

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/decimal.rst View 1 chunk +13 lines, -0 lines 3 comments Download
Lib/_pydecimal.py View 1 chunk +52 lines, -0 lines 0 comments Download
Lib/test/test_decimal.py View 1 chunk +33 lines, -0 lines 0 comments Download
Modules/_decimal/_decimal.c View 2 chunks +103 lines, -0 lines 6 comments Download
Modules/_decimal/docstrings.h View 1 chunk +9 lines, -0 lines 0 comments Download
Modules/_decimal/tests/deccheck.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
storchaka_gmail.com
LGTM. Only left few nitpicks. http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst File Doc/library/decimal.rst (right): http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst#newcode460 Doc/library/decimal.rst:460: The conversion is exact. ...
1 year, 9 months ago #1
skrah
http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst File Doc/library/decimal.rst (right): http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst#newcode460 Doc/library/decimal.rst:460: The conversion is exact. Raise OverflowError on infinities and ...
1 year, 9 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst File Doc/library/decimal.rst (right): http://bugs.python.org/review/25928/diff/16243/Doc/library/decimal.rst#newcode460 Doc/library/decimal.rst:460: The conversion is exact. Raise OverflowError on infinities and ...
1 year, 9 months ago #3
skrah
1 year, 9 months ago #4
http://bugs.python.org/review/25928/diff/16243/Modules/_decimal/_decimal.c
File Modules/_decimal/_decimal.c (right):

http://bugs.python.org/review/25928/diff/16243/Modules/_decimal/_decimal.c#ne...
Modules/_decimal/_decimal.c:3400: "cannot convert NaN to integer ratio");
Maybe. If we really want to go that far: The docstrings also differ between the
Python/C versions. I took the docstring from float.as_integer_ratio().

The problem (as always) is: How to get approval from all people who authored the
texts?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7