Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

#25913: base64.a85decode adobe flag incorrectly utilizes <~ as a marker causing error

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by sorensolari
Modified:
4 years ago
Reviewers:
storchaka, jaiswalswati94
CC:
terry.reedy, AntoinePitrou, devnull_psf.upfronthosting.co.za, storchaka, isoschiz, curioswati, sorensolari_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/base64.py View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
Lib/test/test_base64.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6
storchaka_gmail.com
http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py File Lib/test/test_base64.py (left): http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py#oldcode571 Lib/test/test_base64.py:571: self.assertRaises(ValueError, base64.a85decode, Needed a test for well-formed data without ...
4 years, 1 month ago #1
curioswati
http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py File Lib/test/test_base64.py (left): http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py#oldcode571 Lib/test/test_base64.py:571: self.assertRaises(ValueError, base64.a85decode, On 2015/12/23 11:12:59, storchaka wrote: > Needed ...
4 years, 1 month ago #2
curioswati
4 years, 1 month ago #3
storchaka_gmail.com
http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py File Lib/test/test_base64.py (left): http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py#oldcode571 Lib/test/test_base64.py:571: self.assertRaises(ValueError, base64.a85decode, On 2015/12/31 18:23:27, curioswati wrote: > On ...
4 years ago #4
storchaka_gmail.com
4 years ago #5
curioswati
4 years ago #6
http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py
File Lib/test/test_base64.py (left):

http://bugs.python.org/review/25913/diff/16222/Lib/test/test_base64.py#oldcod...
Lib/test/test_base64.py:571: self.assertRaises(ValueError, base64.a85decode,
On 2016/01/12 09:57:38, storchaka wrote:
> On 2015/12/31 18:23:27, curioswati wrote:
> > On 2015/12/23 11:12:59, storchaka wrote:
> > > Needed a test for well-formed data without starting Adobe framing marker.
> > 
> > Well-formed means? Sorry I didn't get what you mean. Do I need to put an
> > assertTrue for the acceptable string instead of removing the assertRaise?
> 
> Please add assertEqual for the acceptable string without the "<~" prefix. May
be
> the better place for this test is test_a85decode.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+