Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192663)

#25660: tabs don't work correctly in python repl

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by yselivanov
Modified:
3 years, 8 months ago
Reviewers:
vadmium+py
CC:
Ronald Oussoren, Nick Coghlan, larry, ned.deily, r.david.murray, Yury.Selivanov, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, Yury Selivanov, clement.pit_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/rlcompleter.py View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 2
Martin Panter
https://bugs.python.org/review/25660/diff/15987/Lib/rlcompleter.py File Lib/rlcompleter.py (right): https://bugs.python.org/review/25660/diff/15987/Lib/rlcompleter.py#newcode80 Lib/rlcompleter.py:80: return '' Might be better to return None (indicates ...
3 years, 8 months ago #1
Yury Selivanov
3 years, 8 months ago #2
http://bugs.python.org/review/25660/diff/15987/Lib/rlcompleter.py
File Lib/rlcompleter.py (right):

http://bugs.python.org/review/25660/diff/15987/Lib/rlcompleter.py#newcode80
Lib/rlcompleter.py:80: return ''
On 2015/11/21 00:28:23, vadmium wrote:
> Might be better to return None (indicates no more completions), rather than
the
> empty string.

We need to return an empty string here, otherwise, readline thinks that
completion fails and first tab keypress is swallowed.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+