Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

#25658: PyThread assumes pthread_key_t is an integer, which is against POSIX

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by ed
Modified:
4 months, 4 weeks ago
Reviewers:
ncoghlan, erik.m.bray, ma3yuki.8mamo10
CC:
Nick Coghlan, haypo, r.david.murray, erik.bray, masamoto, EdSchouten
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 8

Patch Set 5 #

Total comments: 7

Patch Set 6 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/pythread.h View 1 2 3 4 5 3 chunks +62 lines, -9 lines 0 comments Download
Modules/_testcapimodule.c View 1 2 3 4 5 2 chunks +46 lines, -0 lines 5 comments Download
Modules/_tracemalloc.c View 1 2 3 4 5 5 chunks +8 lines, -10 lines 0 comments Download
Modules/faulthandler.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
Modules/signalmodule.c View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
Python/pystate.c View 1 2 3 4 5 11 chunks +25 lines, -28 lines 0 comments Download
Python/thread.c View 1 2 3 4 5 12 chunks +95 lines, -26 lines 0 comments Download
Python/thread_foobar.h View 1 2 3 4 5 3 chunks +68 lines, -1 line 0 comments Download
Python/thread_nt.h View 1 2 3 4 5 5 chunks +80 lines, -7 lines 0 comments Download
Python/thread_pthread.h View 1 2 3 4 5 3 chunks +83 lines, -2 lines 0 comments Download
Python/traceback.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
configure View 1 2 3 4 5 1 chunk +69 lines, -0 lines 0 comments Download
configure.ac View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
pyconfig.h.in View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Nick Coghlan
Aside from the accidentally added file, this generally looks good to me Just one suggested ...
9 months, 1 week ago #1
erik.bray
On 2016/12/19 12:53:50, Nick Coghlan wrote: > Aside from the accidentally added file, this generally ...
9 months, 1 week ago #2
masamoto
http://bugs.python.org/review/25658/diff/19359/Modules/_tracemalloc.c File Modules/_tracemalloc.c (right): http://bugs.python.org/review/25658/diff/19359/Modules/_tracemalloc.c#newcode171 Modules/_tracemalloc.c:171: static bool key_used = false; Yes, it's a flag ...
9 months, 1 week ago #3
masamoto
Renaming PyThread_ReInitTLS occurs to need update for Modules/signalmodule.c since the function has been used there. ...
8 months, 1 week ago #4
erik.bray
4 months, 4 weeks ago #5
I added just a few minor nitpicks on the test error messages.  Other than that I
think everything else has been addressed.

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c
File Modules/_testcapimodule.c (right):

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c#newc...
Modules/_testcapimodule.c:4050: "initialization");
Just a minor English nitpick--this should be something like "TSS key not in an
uninitialized state at creation time"

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c#newc...
Modules/_testcapimodule.c:4059: "but tss key didn't make created state");
"PyThread_tss_create succeeded, but with TSS key in an uninitialized state"

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c#newc...
Modules/_testcapimodule.c:4064: "created key");
"PyThread_tss_create unsuccessful with an already initialized key"

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c#newc...
Modules/_testcapimodule.c:4071: "wasn't kept after calling " #expr); }
"TSS key initialization state was not preserved after calling " #expr

http://bugs.python.org/review/25658/diff/19806/Modules/_testcapimodule.c#newc...
Modules/_testcapimodule.c:4080: "but tss key didn't make non created state");
"PyThread_tss_delete called, but did not set the key state to uninitialized" (or
something like that)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7