Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

#25591: improve test coverage for the imaplib

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by soltysh
Modified:
3 years, 3 months ago
Reviewers:
rdmurray
CC:
barry, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka, maciej.szulik
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 43

Patch Set 3 #

Total comments: 4

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_imaplib.py View 1 2 3 2 chunks +320 lines, -0 lines 0 comments Download

Messages

Total messages: 6
r.david.murray
In general this looks very good, and I find it easier to follow than the ...
3 years, 9 months ago #1
maciej.szulik
I've addressed the comments. I'll upload the entire patch but only the changes from this ...
3 years, 7 months ago #2
r.david.murray
http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py File Lib/test/test_imaplib.py (right): http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py#newcode199 Lib/test/test_imaplib.py:199: name=self._server.__class__.__name__, On 2016/05/26 23:55:51, maciej.szulik wrote: > On 2016/04/10 ...
3 years, 6 months ago #3
maciej.szulik
http://bugs.python.org/review/25591/diff/17366/Lib/test/test_imaplib.py File Lib/test/test_imaplib.py (right): http://bugs.python.org/review/25591/diff/17366/Lib/test/test_imaplib.py#newcode259 Lib/test/test_imaplib.py:259: with self.assertRaisesRegex(imaplib.IMAP4.error, 'does not support ENABLE'): On 2016/07/19 02:24:55, ...
3 years, 3 months ago #4
maciej.szulik
http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py File Lib/test/test_imaplib.py (right): http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py#newcode199 Lib/test/test_imaplib.py:199: name=self._server.__class__.__name__, On 2016/07/19 02:24:54, r.david.murray wrote: > On 2016/05/26 ...
3 years, 3 months ago #5
maciej.szulik
3 years, 3 months ago #6
http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py
File Lib/test/test_imaplib.py (right):

http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py#newco...
Lib/test/test_imaplib.py:451: def test_ssl_raises(self):
On 2016/09/30 22:38:17, maciej.szulik wrote:
> On 2016/07/19 02:24:55, r.david.murray wrote:
> > On 2016/05/26 23:55:51, maciej.szulik wrote:
> > > First of all, I don't feel strong enough to explain SSL here, yet :/ As
for
> > the
> > > hostname validation, according to my tests it's False right now.
> > > 
> > > 
> > > On 2016/04/10 23:10:26, r.david.murray wrote:
> > > > So this is provoking an arbitrary SSL error and making sure it is raised
> as
> > an
> > > > SSL error?  If so a comment to that effect would be good.
> > > > 
> > > > However, I suspect we should be testing that hostname validation is on
by
> > > > default.
> > > 
> > 
> > Hmm.  If hostname validation is False by default for imaplib, that's
something
> > that Christian Heims will be interested in, since I thought he made it True
by
> > default for the default context used by the stdlib.
> 
> Clearly it's False, just make a quick test:
> 
> Python 3.7.0a0 (default:a2ff43d50337, Sep 30 2016, 22:04:55) 
> [GCC 6.2.1 20160916 (Red Hat 6.2.1-2)] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>> import ssl
> >>> c = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
> >>> c.check_hostname
> False

I've created http://bugs.python.org/issue28320 to clear this out.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+