Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

#25485: Add a context manager to telnetlib.Telnet

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by dutch109
Modified:
1 year, 10 months ago
Reviewers:
ghost.adh, stephane, victor.stinner
CC:
r.david.murray, SilentGhost, devnull_psf.upfronthosting.co.za, berkerpeksag, desbma, matrixise
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 5

Patch Set 4 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/telnetlib.rst View 1 2 3 1 chunk +10 lines, -0 lines 2 comments Download
Lib/telnetlib.py View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
Lib/test/test_telnetlib.py View 1 2 3 1 chunk +5 lines, -0 lines 1 comment Download
Misc/NEWS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
ghost.adh_gmail.com
https://bugs.python.org/review/25485/diff/16002/Doc/library/telnetlib.rst File Doc/library/telnetlib.rst (right): https://bugs.python.org/review/25485/diff/16002/Doc/library/telnetlib.rst#newcode46 Doc/library/telnetlib.rst:46: :class:`Telnet` class support the :keyword:`with` statement. Here is a ...
1 year, 11 months ago #1
matrixise
https://bugs.python.org/review/25485/diff/16002/Doc/library/telnetlib.rst File Doc/library/telnetlib.rst (right): https://bugs.python.org/review/25485/diff/16002/Doc/library/telnetlib.rst#newcode46 Doc/library/telnetlib.rst:46: :class:`Telnet` class support the :keyword:`with` statement. Here is a ...
1 year, 11 months ago #2
ghost.adh_gmail.com
https://bugs.python.org/review/25485/diff/16002/Misc/NEWS File Misc/NEWS (right): https://bugs.python.org/review/25485/diff/16002/Misc/NEWS#newcode13 Misc/NEWS:13: - Issue #25485: Add the support of the `with` ...
1 year, 11 months ago #3
haypo
Please replace "with statement" with "context manager protocol". https://bugs.python.org/review/25485/diff/16014/Doc/library/telnetlib.rst File Doc/library/telnetlib.rst (right): https://bugs.python.org/review/25485/diff/16014/Doc/library/telnetlib.rst#newcode46 Doc/library/telnetlib.rst:46: :class:`Telnet` ...
1 year, 10 months ago #4
ghost.adh_gmail.com
1 year, 10 months ago #5
https://bugs.python.org/review/25485/diff/16014/Doc/library/telnetlib.rst
File Doc/library/telnetlib.rst (right):

https://bugs.python.org/review/25485/diff/16014/Doc/library/telnetlib.rst#new...
Doc/library/telnetlib.rst:46: :class:`Telnet` class supports the with statement,
e.g:
On 2015/11/25 14:45:33, haypo wrote:
> hum, I think that it's called the "context manager" protocol. You can add a
link
> to "context manager" in the glossary. Try :term:`context manager`, I'm not
sure
> of the markup.
While I agree that that would be a more proper description, this is the language
that was used to describe addition of support for context-manager protocol in
all recent modules. I think the consistency should prevail here.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7