Issue 25483: Improve f-string implementation: FORMAT_VALUE opcode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#25483: Improve f-string implementation: FORMAT_VALUE opcode

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 5 months ago by eric

Modified:
3 years, 5 months ago

Reviewers:
larry

CC:
brett.cannon, larry, eric.smith, skrah, Mark.Shannon, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka

Visibility:
Public.

Patch Set 4 #

Created: 3 years, 5 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Include/ceval.h	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
Include/opcode.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
Lib/importlib/_bootstrap_external.py	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
Lib/opcode.py	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
Python/ceval.c	View	1 2 3	1 chunk	+57 lines, -0 lines	0 comments	Download
Python/compile.c	View	1 2 3	2 chunks	+41 lines, -71 lines	0 comments	Download
Python/opcode_targets.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

larry

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c File Python/ceval.c (right): http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3374 Python/ceval.c:3374: fmt_spec = (oparg & 0x4) ? POP() : NULL; ...

3 years, 5 months ago #1

eric.smith

3 years, 5 months ago #2

Thanks for the review. I'll address your points.

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c
File Python/ceval.c (right):

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3374
Python/ceval.c:3374: fmt_spec = (oparg & 0x4) ? POP() : NULL;
Good idea.

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3378
Python/ceval.c:3378: case 0x0:
Yes, I just didn't have a good place to put them. I'll stash them in a .h file
somewhere.

http://bugs.python.org/review/25483/diff/15824/Python/compile.c
File Python/compile.c (right):

http://bugs.python.org/review/25483/diff/15824/Python/compile.c#newcode3246
Python/compile.c:3246: /* Note that this code uses the builtin functions
format(), str(),
Thanks.

Expand All Messages | Collapse All Messages

#25483: Improve f-string implementation: FORMAT_VALUE opcode

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Messages