Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(313)

#25483: Improve f-string implementation: FORMAT_VALUE opcode

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 12 months ago by eric
Modified:
1 year, 11 months ago
Reviewers:
larry
CC:
brett.cannon, larry, eric.smith, skrah, Mark.Shannon, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/ceval.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
Include/opcode.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
Lib/importlib/_bootstrap_external.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
Lib/opcode.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
Python/ceval.c View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
Python/compile.c View 1 2 3 2 chunks +41 lines, -71 lines 0 comments Download
Python/opcode_targets.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
larry
http://bugs.python.org/review/25483/diff/15824/Python/ceval.c File Python/ceval.c (right): http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3374 Python/ceval.c:3374: fmt_spec = (oparg & 0x4) ? POP() : NULL; ...
1 year, 11 months ago #1
eric.smith
1 year, 11 months ago #2
Thanks for the review. I'll address your points.

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c
File Python/ceval.c (right):

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3374
Python/ceval.c:3374: fmt_spec = (oparg & 0x4) ? POP() : NULL;
Good idea.

http://bugs.python.org/review/25483/diff/15824/Python/ceval.c#newcode3378
Python/ceval.c:3378: case 0x0:
Yes, I just didn't have a good place to put them. I'll stash them in a .h file
somewhere.

http://bugs.python.org/review/25483/diff/15824/Python/compile.c
File Python/compile.c (right):

http://bugs.python.org/review/25483/diff/15824/Python/compile.c#newcode3246
Python/compile.c:3246: /* Note that this code uses the builtin functions
format(), str(),
Thanks.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7