Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

#25357: Add an optional newline parameter to binascii.b2a_base64() to not add a newline

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by victor.stinner
Modified:
2 years ago
Reviewers:
storchaka, vadmium+py
CC:
Nick Coghlan, AntoinePitrou, haypo, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/binascii.rst View 1 1 chunk +4 lines, -3 lines 2 comments Download
Lib/base64.py View 1 1 chunk +1 line, -2 lines 0 comments Download
Lib/test/test_binascii.py View 1 1 chunk +10 lines, -0 lines 0 comments Download
Modules/binascii.c View 1 3 chunks +11 lines, -6 lines 1 comment Download
Modules/clinic/binascii.c.h View 1 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3
storchaka_gmail.com
https://bugs.python.org/review/25357/diff/15735/Doc/library/binascii.rst File Doc/library/binascii.rst (right): https://bugs.python.org/review/25357/diff/15735/Doc/library/binascii.rst#newcode58 Doc/library/binascii.rst:58: value is the converted line, including a newline char ...
2 years ago #1
Martin Panter
https://bugs.python.org/review/25357/diff/15737/Doc/library/binascii.rst File Doc/library/binascii.rst (right): https://bugs.python.org/review/25357/diff/15737/Doc/library/binascii.rst#newcode60 Doc/library/binascii.rst:60: base64 standard. .. versionchanged:: 3.6 Added the *newline* parameter. ...
2 years ago #2
haypo
2 years ago #3
https://bugs.python.org/review/25357/diff/15735/Doc/library/binascii.rst
File Doc/library/binascii.rst (right):

https://bugs.python.org/review/25357/diff/15735/Doc/library/binascii.rst#newc...
Doc/library/binascii.rst:58: value is the converted line, including a newline
char if *newline* is
On 2015/10/09 18:35:27, storchaka wrote:
> "is true", without title case and highlighting. Some other true values besides
> True are accepted.

Done.

https://bugs.python.org/review/25357/diff/15735/Modules/binascii.c
File Modules/binascii.c (right):

https://bugs.python.org/review/25357/diff/15735/Modules/binascii.c#newcode532
Modules/binascii.c:532: newline: int = 1
On 2015/10/09 18:35:27, storchaka wrote:
> newline: int(c_default="1") = True

Done.

https://bugs.python.org/review/25357/diff/15737/Doc/library/binascii.rst
File Doc/library/binascii.rst (right):

https://bugs.python.org/review/25357/diff/15737/Doc/library/binascii.rst#newc...
Doc/library/binascii.rst:60: base64 standard.
On 2015/10/10 06:00:10, vadmium wrote:
> .. versionchanged:: 3.6
>    Added the *newline* parameter.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7