Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262877)

#25270: codecs.escape_encode systemerror on empty byte string

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by paul.l.kehrer
Modified:
2 years, 11 months ago
Reviewers:
storchaka+cpython, berker.peksag
CC:
lemburg, doerwalter, Benjamin Peterson, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, python.org_the-compiler.org, paul.l.kehrer_gmail.com, nicoddemus_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 7

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/bytes.rst View 1 2 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_codecs.py View 1 2 1 chunk +21 lines, -0 lines 1 comment Download
Objects/bytesobject.c View 1 2 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 4
storchaka
https://bugs.python.org/review/25270/diff/18575/Lib/test/test_codecs.py File Lib/test/test_codecs.py (right): https://bugs.python.org/review/25270/diff/18575/Lib/test/test_codecs.py#newcode2551 Lib/test/test_codecs.py:2551: (b'spam\0eggs', (b'spam\\x00eggs', 9)), Please add tests for '\'', '\\', ...
2 years, 11 months ago #1
berkerpeksag
Thanks for the review, Serhiy. By the way, return value of _PyBytes_Resize() didn't checked in ...
2 years, 11 months ago #2
storchaka
On 2016/09/16 12:41:15, berkerpeksag wrote: > Thanks for the review, Serhiy. > > By the ...
2 years, 11 months ago #3
storchaka
2 years, 11 months ago #4
LGTM, except one duplication in tests.

http://bugs.python.org/review/25270/diff/18577/Lib/test/test_codecs.py
File Lib/test/test_codecs.py (right):

http://bugs.python.org/review/25270/diff/18577/Lib/test/test_codecs.py#newcod...
Lib/test/test_codecs.py:2557: (b'h\ri', (b'h\\ri', 3)),
Duplicates (b'd\re', (b'd\\re', 3))
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+