Issue 25111: Broken compatibility in FrameSummary equality

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#25111: Broken compatibility in FrameSummary equality

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 11 months ago by storchaka+cpython

Modified:
3 years, 10 months ago

Reviewers:
victor.stinner

CC:
haypo, rbcollins, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka

Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Created: 3 years, 11 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/test/test_traceback.py	View	1	2 chunks	+8 lines, -4 lines	1 comment	Download
		Lib/traceback.py	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

victor.stinner_gmail.com

3 years, 10 months ago #1

http://bugs.python.org/review/25111/diff/15571/Lib/test/test_traceback.py
File Lib/test/test_traceback.py (right):

http://bugs.python.org/review/25111/diff/15571/Lib/test/test_traceback.py#new...
Lib/test/test_traceback.py:660: self.assertEqual(f, tuple(f))
I don't understand why you test "f == tuple(f)" and "tuple(f) == f". It isn't
the same? Just a comment to explain why.

Expand All Messages | Collapse All Messages