Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268925)

#25111: Broken compatibility in FrameSummary equality

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by storchaka+cpython
Modified:
3 years, 10 months ago
Reviewers:
victor.stinner
CC:
haypo, rbcollins, devnull_psf.upfronthosting.co.za, berkerpeksag, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_traceback.py View 1 2 chunks +8 lines, -4 lines 1 comment Download
Lib/traceback.py View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 1
victor.stinner_gmail.com
3 years, 10 months ago #1
http://bugs.python.org/review/25111/diff/15571/Lib/test/test_traceback.py
File Lib/test/test_traceback.py (right):

http://bugs.python.org/review/25111/diff/15571/Lib/test/test_traceback.py#new...
Lib/test/test_traceback.py:660: self.assertEqual(f, tuple(f))
I don't understand why you test "f == tuple(f)" and "tuple(f) == f". It isn't
the same? Just a comment to explain why.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+