Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82278)

#25099: test_compileall fails when run by unprivileged user on installed Python

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by zachary.ware
Modified:
3 years, 10 months ago
Reviewers:
storchaka, brett
CC:
brett.cannon, Georg, pmoore, Nick Coghlan, tim.golden, Benjamin Peterson, devnull_psf.upfronthosting.co.za, eric.snow, Zach Ware, storchaka, steve.dower
Visibility:
Public.

Patch Set 1 #

Total comments: 8

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_compileall.py View 1 2 6 chunks +31 lines, -4 lines 2 comments Download

Messages

Total messages: 6
storchaka_gmail.com
https://bugs.python.org/review/25099/diff/15633/Lib/test/test_compileall.py File Lib/test/test_compileall.py (right): https://bugs.python.org/review/25099/diff/15633/Lib/test/test_compileall.py#newcode168 Lib/test/test_compileall.py:168: for path in filter(os.path.isdir, sys.path): I think it would ...
3 years, 10 months ago #1
brett.cannon
New patch coming that addresses Serhiy's comments. https://bugs.python.org/review/25099/diff/15633/Lib/test/test_compileall.py File Lib/test/test_compileall.py (right): https://bugs.python.org/review/25099/diff/15633/Lib/test/test_compileall.py#newcode168 Lib/test/test_compileall.py:168: for path ...
3 years, 10 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/25099/diff/15738/Lib/test/test_compileall.py File Lib/test/test_compileall.py (right): http://bugs.python.org/review/25099/diff/15738/Lib/test/test_compileall.py#newcode179 Lib/test/test_compileall.py:179: directory.mkdir() The probing can have a side effect. It ...
3 years, 10 months ago #3
brett.cannon
Hopefully the time comments will be needed. =) http://bugs.python.org/review/25099/diff/15738/Lib/test/test_compileall.py File Lib/test/test_compileall.py (right): http://bugs.python.org/review/25099/diff/15738/Lib/test/test_compileall.py#newcode179 Lib/test/test_compileall.py:179: directory.mkdir() ...
3 years, 10 months ago #4
storchaka_gmail.com
http://bugs.python.org/review/25099/diff/15739/Lib/test/test_compileall.py File Lib/test/test_compileall.py (right): http://bugs.python.org/review/25099/diff/15739/Lib/test/test_compileall.py#newcode187 Lib/test/test_compileall.py:187: support.unlink(str(path)) Missed "finally:"?
3 years, 10 months ago #5
brett.cannon
3 years, 10 months ago #6
If the best Serhiy can find is a missing `finally` clause then I consider this
patch complete with the addition of that missing clause.

http://bugs.python.org/review/25099/diff/15739/Lib/test/test_compileall.py
File Lib/test/test_compileall.py (right):

http://bugs.python.org/review/25099/diff/15739/Lib/test/test_compileall.py#ne...
Lib/test/test_compileall.py:187: support.unlink(str(path))
On 2015/10/09 23:39:44, storchaka wrote:
> Missed "finally:"?

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+