Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Unified Diff: Doc/library/socket.rst

Issue 25041: document AF_PACKET socket address format
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
--- a/Doc/library/socket.rst Thu Oct 29 09:53:33 2015 +0200
+++ b/Doc/library/socket.rst Thu Oct 29 22:07:04 2015 +0000
@@ -128,8 +128,15 @@
string format. (ex. ``b'12:23:34:45:56:67'``) This protocol is not
supported under FreeBSD.
-- Certain other address families (:const:`AF_PACKET`, :const:`AF_CAN`)
- support specific representations.
+- A tuple ``(interface, eth_prot, pkttype, ha_type, addr, addr_len``, )
berkerpeksag 2015/10/30 08:15:14 addr_len``, ) should read addr_len)``
Martin Panter 2015/10/31 05:01:45 Perhaps use the square bracket notation (as for AF
+ is used for the :const:`AF_PACKET` address family, where ``interface`` is a
berkerpeksag 2015/10/30 08:15:14 Double space before :const:`AF_PACKET`.
berkerpeksag 2015/10/30 08:15:14 ``interface`` -> *interface* ``eth_prot`` -> *eth
+ string specifying the Ethernet interface, ``eth_prot`` is an integer
+ specifying the Ethernet protocol, ``pkttype`` is an optional constant
+ specifying the packet type (for example, ``PACKET_HOST``), ``ha_type``
+ is an optional integer specifying the ARP hardware type, ``addr`` and
Martin Panter 2015/10/31 05:01:45 Not sure but it might be more correct to refer to
+ ``addr_len`` are optional arguments specifying the physical address
Martin Panter 2015/10/31 05:01:45 Address length is implied in the length of “addr”,
+ and its length.
+
.. XXX document them!
Martin Panter 2015/10/31 05:01:45 Remove this
« no previous file with comments | « no previous file | no next file » | no next file with comments »

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+