Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12154)

#24802: PyFloat_FromString Buffer Over-read

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by john
Modified:
3 years, 10 months ago
Reviewers:
storchaka, vadmium+py
CC:
mark.dickinson, eric.smith, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka, JohnLeitch
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_builtin.py View 1 1 chunk +20 lines, -0 lines 4 comments Download
Lib/test/test_float.py View 1 3 chunks +36 lines, -2 lines 0 comments Download
Lib/test/test_int.py View 1 1 chunk +33 lines, -9 lines 0 comments Download
Misc/NEWS View 1 1 chunk +4 lines, -0 lines 2 comments Download
Objects/abstract.c View 1 1 chunk +20 lines, -2 lines 0 comments Download
Objects/complexobject.c View 1 4 chunks +0 lines, -7 lines 0 comments Download
Objects/floatobject.c View 1 1 chunk +15 lines, -0 lines 0 comments Download
Python/bltinmodule.c View 1 9 chunks +32 lines, -16 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/24802/diff/15878/Lib/test/test_builtin.py File Lib/test/test_builtin.py (right): http://bugs.python.org/review/24802/diff/15878/Lib/test/test_builtin.py#newcode350 Lib/test/test_builtin.py:350: def test_compile_null_terminated(self): May be add this test to test_compile? ...
3 years, 10 months ago #1
Martin Panter
3 years, 10 months ago #2
https://bugs.python.org/review/24802/diff/15878/Lib/test/test_builtin.py
File Lib/test/test_builtin.py (right):

https://bugs.python.org/review/24802/diff/15878/Lib/test/test_builtin.py#newc...
Lib/test/test_builtin.py:350: def test_compile_null_terminated(self):
On 2015/11/05 21:18:36, storchaka wrote:
> May be add this test to test_compile?

Okay I’ll try it there since you mentioned it.

https://bugs.python.org/review/24802/diff/15878/Lib/test/test_builtin.py#newc...
Lib/test/test_builtin.py:366: namespace = dict()
On 2015/11/05 21:18:36, storchaka wrote:
> namespace = {}

I prefer dict() if you don’t mind. It looks a lot less like an empty set.

https://bugs.python.org/review/24802/diff/15878/Misc/NEWS
File Misc/NEWS (right):

https://bugs.python.org/review/24802/diff/15878/Misc/NEWS#newcode14
Misc/NEWS:14: and eval() are passed bytes-like objects. These objects are not
necessarily
On 2015/11/05 21:18:36, storchaka wrote:
> Nitpick: PEP 8 and PEP 9 recommend to use two spaces after a sentence-ending
> period.

Thanks for the pointer. I’ve seen this style in roughly 50% of cases, and
usually try to conform to the surrounding text, but sometimes my own style
(single space) slips through.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+