Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170709)

#24801: right-mouse click in IDLE on Mac doesn't work

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by mark
Modified:
4 years, 4 months ago
Reviewers:
storchaka
CC:
terry.reedy, Ronald Oussoren, ned.deily, markroseman, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/idlelib/EditorWindow.py View 1 1 chunk +5 lines, -5 lines 0 comments Download
Lib/idlelib/PyShell.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/24801/diff/15345/Lib/idlelib/EditorWindow.py File Lib/idlelib/EditorWindow.py (right): http://bugs.python.org/review/24801/diff/15345/Lib/idlelib/EditorWindow.py#newcode180 Lib/idlelib/EditorWindow.py:180: text.bind_class('Text', '<B2>', '') unbind_class()? And as long as these ...
4 years, 4 months ago #1
markroseman
4 years, 4 months ago #2
If no other issues, I'll submit a new patch which will change these to
unbind_class(), and move them (for now) into PyShell right below where we start
Tk.

https://bugs.python.org/review/24801/diff/15345/Lib/idlelib/EditorWindow.py
File Lib/idlelib/EditorWindow.py (right):

https://bugs.python.org/review/24801/diff/15345/Lib/idlelib/EditorWindow.py#n...
Lib/idlelib/EditorWindow.py:180: text.bind_class('Text', '<B2>', '')
Yes, unbind_class would be better (I learn something new every day!)

And also yes, placing these in a central initialization routine would be better.
I put them here because I expect these kind of things to go into the new
uifactory initialization code (which hasn't been checked in yet).

On 2015/08/14 16:33:14, storchaka wrote:
> unbind_class()?
> 
> And as long as these unbindings are global, may be move them to global IDLE
> initialization procedure?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+