Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

#24773: Add local time disambiguation flag to datetime

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by alexander.belopolsky
Modified:
1 year, 4 months ago
Reviewers:
songofacandy
CC:
tim.peters, sasha, haypo, stub, akira, devnull_psf.upfronthosting.co.za, Martin Panter, koobs
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 18

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/datetime.h View 1 2 3 4 5 6 chunks +17 lines, -0 lines 0 comments Download
Lib/datetime.py View 1 2 3 4 5 29 chunks +172 lines, -70 lines 0 comments Download
Lib/test/datetimetester.py View 1 2 3 4 5 8 chunks +800 lines, -7 lines 0 comments Download
Lib/test/libregrtest/cmdline.py View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
Misc/NEWS View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
Modules/_datetimemodule.c View 1 2 3 4 5 53 chunks +530 lines, -153 lines 0 comments Download
Tools/tz/zdump.py View 1 2 3 4 5 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 2
inada.naoki
http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c File Modules/_datetimemodule.c (right): http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newcode682 Modules/_datetimemodule.c:682: int second, int usecond, PyObject *tzinfo, int fold, PyTypeObject ...
1 year, 5 months ago #1
sasha
1 year, 5 months ago #2
http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c
File Modules/_datetimemodule.c (right):

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:682: int second, int usecond, PyObject *tzinfo, int
fold, PyTypeObject *type)
On 2016/07/18 03:44:35, naoki wrote:
> hanging indent

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:706: int second, int usecond, PyObject *tzinfo,
PyTypeObject *type)
On 2016/07/18 03:44:35, naoki wrote:
> hanging indent

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:719: PyObject *tzinfo, int fold, PyTypeObject *type)
On 2016/07/18 03:44:35, naoki wrote:
> hanging indent

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:3591: if (PyArg_ParseTupleAndKeywords(args, kw,
"|iiiiOi", time_kws,
On 2016/07/18 03:44:35, naoki wrote:
> Use `$`

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:3599: type);
On 2016/07/18 03:44:35, naoki wrote:
> indent

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:3913: if (! PyArg_ParseTupleAndKeywords(args, kw,
"|iiiiOi:replace",
On 2016/07/18 03:44:35, naoki wrote:
> Use `$`

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:4165: if (PyArg_ParseTupleAndKeywords(args, kw,
"iii|iiiiOi", datetime_kws,
On 2016/07/18 03:44:35, naoki wrote:
> Use `$`

Done.

http://bugs.python.org/review/24773/diff/17891/Modules/_datetimemodule.c#newc...
Modules/_datetimemodule.c:4801: Py_DECREF(flip_offset);
On 2016/07/18 03:44:35, naoki wrote:
> label should be dedented.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7