Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151141)

#24745: Better default font for editor

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by mark
Modified:
4 years, 4 months ago
Reviewers:
tjreedy
CC:
terry.reedy, kbk, larry, Benjamin Peterson, ned.deily, serwy, markroseman, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/idlelib/configDialog.py View 3 chunks +18 lines, -20 lines 2 comments Download
Lib/idlelib/configHandler.py View 2 chunks +28 lines, -0 lines 3 comments Download
Lib/idlelib/config-main.def View 1 chunk +1 line, -1 line 0 comments Download
Lib/idlelib/EditorWindow.py View 2 chunks +4 lines, -14 lines 2 comments Download

Messages

Total messages: 1
terry.reedy
4 years, 4 months ago #1
Minor changes, tested and committed.

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/EditorWindow.py
File Lib/idlelib/EditorWindow.py (right):

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/EditorWindow.py#n...
Lib/idlelib/EditorWindow.py:233: text.config(font=idleConf.GetFont(self.root,
'main', 'EditorWindow'))
text['font'] = ...

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/EditorWindow.py#n...
Lib/idlelib/EditorWindow.py:795:
self.text.config(font=idleConf.GetFont(self.root, 'main',
ditto

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configDialog.py
File Lib/idlelib/configDialog.py (right):

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configDialog.py#n...
Lib/idlelib/configDialog.py:964: fontBold  = 1 if configuredFont[2]=='bold' else
0
fontBold = configuredFont[2]=='bold'

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configDialog.py#n...
Lib/idlelib/configDialog.py:967: if fontName in lc_fonts:
try:
    ...
except ValueError:pass

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configHandler.py
File Lib/idlelib/configHandler.py (right):

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configHandler.py#...
Lib/idlelib/configHandler.py:25: from tkinter import *
Not needed

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configHandler.py#...
Lib/idlelib/configHandler.py:692: f = Font(name = 'TkFixedFont', exists = True,
root = root)
No space around = in calls (pep8)

https://bugs.python.org/review/24745/diff/15317/Lib/idlelib/configHandler.py#...
Lib/idlelib/configHandler.py:698: bold = 1 if actualFont['weight']=='bold' else
0
bold = actualFont['weight']=='bold'
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+