Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

#2466: os.path.ismount doesn't work for mounts the user doesn't have permission to see

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by ross.burton
Modified:
3 years, 5 months ago
Reviewers:
ghost.adh
CC:
loewis, AntoinePitrou, ross.burton_intel.com, r.david.murray, devnull_psf.upfronthosting.co.za, dave_pandora.com, berkerpeksag, storchaka, pablo.sole_gmail.com, xiang.zhang, robinro
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_posixpath.py View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1
SilentGhost
3 years, 8 months ago #1
https://bugs.python.org/review/2466/diff/15956/Lib/posixpath.py
File Lib/posixpath.py (right):

https://bugs.python.org/review/2466/diff/15956/Lib/posixpath.py#newcode197
Lib/posixpath.py:197: parent = realpath(parent)
If this line is the only relevant code change - it would make sense to not have
any other changes - no matter how trivial.

https://bugs.python.org/review/2466/diff/15956/Lib/posixpath.py#newcode208
Lib/posixpath.py:208: if s1.st_ino == s2.st_ino:
From here until the end of function the code can be reduced to:

return s1.st_ino == s2.st_ino
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+