Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158585)

#24420: Documentation regressions from adding subprocess.run()

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by vadmium+py
Modified:
4 years, 5 months ago
Reviewers:
berker.peksag
CC:
docs_python.org, devnull_psf.upfronthosting.co.za, Thomas Kluyver, berkerpeksag, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/subprocess.rst View 1 6 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 3
berkerpeksag
http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst File Doc/library/subprocess.rst (right): http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst#newcode880 Doc/library/subprocess.rst:880: .. function:: check_output(args, *[, input], stdin=None, stderr=None, shell=False, universal_newlines=False, ...
4 years, 5 months ago #1
Martin Panter
http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst File Doc/library/subprocess.rst (right): http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst#newcode880 Doc/library/subprocess.rst:880: .. function:: check_output(args, *[, input], stdin=None, stderr=None, shell=False, universal_newlines=False, ...
4 years, 5 months ago #2
berkerpeksag
4 years, 5 months ago #3
http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst
File Doc/library/subprocess.rst (right):

http://bugs.python.org/review/24420/diff/15059/Doc/library/subprocess.rst#new...
Doc/library/subprocess.rst:880: .. function:: check_output(args, *[, input],
stdin=None, stderr=None, shell=False, universal_newlines=False, timeout=None)
On 2015/06/26 02:32:56, vadmium wrote:
> On 2015/06/25 23:31:14, berkerpeksag wrote:
> > I think we can now remove *input* from the signature.
> 
> Yes I agree. I might tweak the new paragraph and the “versionchanged” note to
> add more context, though.

Yes, that would be better.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+