Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97760)

#24211: Add RFC 6532 support to the email library

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by rdmurray
Modified:
4 years, 6 months ago
Reviewers:
storchaka, soltysh
CC:
barry, r.david.murray, devnull_psf.upfronthosting.co.za, maciej.szulik
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/email.policy.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download
Doc/whatsnew/3.5.rst View 1 1 chunk +6 lines, -0 lines 1 comment Download
Lib/email/_header_value_parser.py View 1 3 chunks +7 lines, -4 lines 1 comment Download
Lib/email/policy.py View 1 4 chunks +14 lines, -1 line 0 comments Download
Lib/test/test_email/test_generator.py View 1 2 chunks +22 lines, -0 lines 0 comments Download
Lib/test/test_email/test_policy.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/24211/diff/14865/Lib/email/_header_value_parser.py File Lib/email/_header_value_parser.py (right): http://bugs.python.org/review/24211/diff/14865/Lib/email/_header_value_parser.py#newcode328 Lib/email/_header_value_parser.py:328: str(part).encode(encoding) str(part) == tstr.
4 years, 6 months ago #1
maciej.szulik
4 years, 6 months ago #2
One small nit, but otherwise the patch looks good, applies cleanly and works as
expected.

http://bugs.python.org/review/24211/diff/14865/Doc/whatsnew/3.5.rst
File Doc/whatsnew/3.5.rst (right):

http://bugs.python.org/review/24211/diff/14865/Doc/whatsnew/3.5.rst#newcode360
Doc/whatsnew/3.5.rst:360: ``True`` to encode email headers using the utf8
charset in stead of using
s/in stead/instead
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+