Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1909)

#24164: Support pickling objects with __new__ with keyword arguments with protocol 2+

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by storchaka+cpython
Modified:
2 years ago
Reviewers:
victor.stinner
CC:
AntoinePitrou, haypo, Alexandre Vassalotti, Arfrever, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/pickle.rst View 1 2 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2
haypo
http://bugs.python.org/review/24164/diff/15744/Doc/library/pickle.rst File Doc/library/pickle.rst (right): http://bugs.python.org/review/24164/diff/15744/Doc/library/pickle.rst#newcode504 Doc/library/pickle.rst:504: :meth:`__getnewargs_ex__` is used in protocols 2 and 3. "is ...
2 years ago #1
storchaka_gmail.com
2 years ago #2
http://bugs.python.org/review/24164/diff/15744/Doc/library/pickle.rst
File Doc/library/pickle.rst (right):

http://bugs.python.org/review/24164/diff/15744/Doc/library/pickle.rst#newcode504
Doc/library/pickle.rst:504: :meth:`__getnewargs_ex__` is used in protocols 2 and
3.
On 2015/10/13 11:49:04, haypo wrote:
> "is *now*" maybe?

Done.

http://bugs.python.org/review/24164/diff/15744/Doc/library/pickle.rst#newcode514
Doc/library/pickle.rst:514: defined.
On 2015/10/13 11:49:04, haypo wrote:
> Hum, you need also a "versionchanged::: 3.6" here no?

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7