Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

#24087: Documentation doesn't explain the term "coroutine" (PEP 342)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by p.f.moore
Modified:
4 years, 7 months ago
Reviewers:
jimjjewett, vadmium+py
CC:
gvanrossum, pmoore, docs_python.org, Martin Panter, csabella
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/glossary.rst View 1 2 chunks +19 lines, -12 lines 1 comment Download
Doc/howto/functional.rst View 1 1 chunk +2 lines, -1 line 0 comments Download
Doc/library/asyncio.rst View 1 1 chunk +2 lines, -1 line 0 comments Download
Doc/library/asyncio-task.rst View 1 1 chunk +3 lines, -1 line 0 comments Download
Doc/library/collections.abc.rst View 1 1 chunk +3 lines, -3 lines 0 comments Download
Doc/library/dis.rst View 1 1 chunk +4 lines, -3 lines 0 comments Download
Doc/library/inspect.rst View 1 3 chunks +6 lines, -10 lines 1 comment Download
Doc/library/sys.rst View 1 2 chunks +4 lines, -3 lines 0 comments Download
Doc/library/types.rst View 1 1 chunk +5 lines, -4 lines 0 comments Download
Doc/reference/compound_stmts.rst View 1 2 chunks +19 lines, -1 line 0 comments Download
Doc/reference/datamodel.rst View 1 2 chunks +5 lines, -5 lines 0 comments Download
Doc/reference/expressions.rst View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Jim.J.Jewett
http://bugs.python.org/review/24087/diff/14757/Doc/glossary.rst File Doc/glossary.rst (right): http://bugs.python.org/review/24087/diff/14757/Doc/glossary.rst#newcode150 Doc/glossary.rst:150: A generator function that works along with an event ...
4 years, 8 months ago #1
Martin Panter
4 years, 7 months ago #2
http://bugs.python.org/review/24087/diff/14757/Doc/glossary.rst
File Doc/glossary.rst (right):

http://bugs.python.org/review/24087/diff/14757/Doc/glossary.rst#newcode150
Doc/glossary.rst:150: A generator function that works along with an event loop
or trampoline
On 2015/04/30 23:22:31, Jim.J.Jewett wrote:
> Is it a "generator function" or just a "generator", with "generator function"
> being the thing you call to create it?  For reference, I'm looking at
> https://docs.python.org/3/reference/expressions.html#yield-expressions

New patch says coroutines may be implemented using generator functions, which
should cover all cases :)

http://bugs.python.org/review/24087/diff/15085/Doc/glossary.rst
File Doc/glossary.rst (right):

http://bugs.python.org/review/24087/diff/15085/Doc/glossary.rst#newcode177
Doc/glossary.rst:177: coroutine to yield control to other routines without
blocking.
Didn’t see the old comment about blocking when I wrote this patch. Perhaps we
should just drop the last bit:

They can be sheduled . . . to allow one coroutine to yield control to other
routines.

http://bugs.python.org/review/24087/diff/15085/Doc/library/inspect.rst
File Doc/library/inspect.rst (left):

http://bugs.python.org/review/24087/diff/15085/Doc/library/inspect.rst#oldcod...
Doc/library/inspect.rst:300: or :func:`asyncio.coroutine`.
Self review: Need to restore @asyncio.coroutine reference
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+