Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

#24033: Update _test_multiprocessing.py to use script helpers

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by bobcatfish
Modified:
4 years, 1 month ago
Reviewers:
ezio.melotti, storchaka
CC:
haypo, ezio.melotti, storchaka, davin, christie
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/support/script_helper.py View 1 4 chunks +64 lines, -30 lines 2 comments Download
Lib/test/test_compile.py View 1 1 chunk +1 line, -1 line 1 comment Download
Lib/test/test_io.py View 1 1 chunk +1 line, -1 line 0 comments Download
Lib/test/_test_multiprocessing.py View 1 3 chunks +36 lines, -21 lines 6 comments Download
Lib/test/test_script_helper.py View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
ezio.melotti
http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing.py File Lib/test/_test_multiprocessing.py (right): http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing.py#newcode4 Lib/test/_test_multiprocessing.py:4: import subprocess This seems unnecessary. http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing.py#newcode3435 Lib/test/_test_multiprocessing.py:3435: import json, ...
4 years, 1 month ago #1
storchaka_gmail.com
4 years, 1 month ago #2
http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing.py
File Lib/test/_test_multiprocessing.py (right):

http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing...
Lib/test/_test_multiprocessing.py:3439: result =
test.support.script_helper.assert_python_ok(
I'm not sure that script_helper.assert_python_ok can be used here. It has too
much magic and adds flags on its own accord. But this test tests running Python
executable just with specified set of flags.

http://bugs.python.org/review/24033/diff/15088/Lib/test/_test_multiprocessing...
Lib/test/_test_multiprocessing.py:3726: import multiprocessing as mp, time, os,
sys
os is not used anymore.

http://bugs.python.org/review/24033/diff/15088/Lib/test/support/script_helper.py
File Lib/test/support/script_helper.py (right):

http://bugs.python.org/review/24033/diff/15088/Lib/test/support/script_helper...
Lib/test/support/script_helper.py:60: command_line_args = [sys.executable, '-X',
'faulthandler']
The old name looks more correct to me. The list represents not only args, but
full command line.

http://bugs.python.org/review/24033/diff/15088/Lib/test/test_compile.py
File Lib/test/test_compile.py (right):

http://bugs.python.org/review/24033/diff/15088/Lib/test/test_compile.py#newco...
Lib/test/test_compile.py:505: res = script_helper.run_python_until_end(fn)
Perhaps new tests using run_python_until_end() were added since this patch was
written.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+