Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(680)

#23883: __all__ lists are incomplete

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by storchaka+cpython
Modified:
1 year, 4 months ago
Reviewers:
vadmium+py, maurosmrodrigues, kolodziejj
CC:
r.david.murray, devnull_psf.upfronthosting.co.za, berkerpeksag, Martin Panter, storchaka, milap.py, maurosr, taddeimania, Unit03, mike_selik.org
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Patch Set 7 #

Total comments: 3

Patch Set 8 #

Patch Set 9 #

Patch Set 10 #

Patch Set 11 #

Patch Set 12 #

Total comments: 2

Patch Set 13 #

Total comments: 10

Patch Set 14 #

Total comments: 21

Patch Set 15 #

Patch Set 16 #

Total comments: 6

Patch Set 17 #

Total comments: 6

Patch Set 18 #

Patch Set 19 #

Patch Set 20 #

Total comments: 6

Patch Set 21 #

Patch Set 22 #

Patch Set 23 #

Patch Set 24 #

Patch Set 25 #

Patch Set 26 #

Patch Set 27 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_pydoc.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Martin Panter
https://bugs.python.org/review/23883/diff/14619/Lib/test/test_tarfile.py File Lib/test/test_tarfile.py (right): https://bugs.python.org/review/23883/diff/14619/Lib/test/test_tarfile.py#newcode1979 Lib/test/test_tarfile.py:1979: 'SubsequentHeaderError', 'nti', 'stn', 'filemode'} What’s with the ordering here? ...
2 years, 4 months ago #1
maurosr
http://bugs.python.org/review/23883/diff/14679/Lib/test/test_fileinput.py File Lib/test/test_fileinput.py (right): http://bugs.python.org/review/23883/diff/14679/Lib/test/test_fileinput.py#newcode894 Lib/test/test_fileinput.py:894: blacklist = {} On 2015/06/17 04:26:07, vadmium wrote: > ...
2 years, 4 months ago #2
Unit03
http://bugs.python.org/review/23883/diff/15093/Lib/test/test_csv.py File Lib/test/test_csv.py (right): http://bugs.python.org/review/23883/diff/15093/Lib/test/test_csv.py#newcode1100 Lib/test/test_csv.py:1100: self.assertEqual(set(csv.__all__), expected) On 2015/06/17 04:26:07, vadmium wrote: > If ...
2 years, 4 months ago #3
Martin Panter
https://bugs.python.org/review/23883/diff/15108/Lib/test/test_pickletools.py File Lib/test/test_pickletools.py (right): https://bugs.python.org/review/23883/diff/15108/Lib/test/test_pickletools.py#newcode65 Lib/test/test_pickletools.py:65: expected = {'SUPPRESS_HELP', 'SUPPRESS_USAGE'} Copy and paste error? https://bugs.python.org/review/23883/diff/15123/Doc/library/test.rst ...
2 years, 3 months ago #4
Unit03
http://bugs.python.org/review/23883/diff/15108/Lib/test/test_pickletools.py File Lib/test/test_pickletools.py (right): http://bugs.python.org/review/23883/diff/15108/Lib/test/test_pickletools.py#newcode65 Lib/test/test_pickletools.py:65: expected = {'SUPPRESS_HELP', 'SUPPRESS_USAGE'} On 2015/06/22 04:31:22, vadmium wrote: ...
2 years, 3 months ago #5
Martin Panter
http://bugs.python.org/review/23883/diff/15153/Lib/test/support/__init__.py File Lib/test/support/__init__.py (right): http://bugs.python.org/review/23883/diff/15153/Lib/test/support/__init__.py#newcode2204 Lib/test/support/__init__.py:2204: def check__all__(test_case, module, name_of_module=None, extra=None, You could simplify the ...
2 years, 3 months ago #6
Unit03
http://bugs.python.org/review/23883/diff/15153/Lib/test/support/__init__.py File Lib/test/support/__init__.py (right): http://bugs.python.org/review/23883/diff/15153/Lib/test/support/__init__.py#newcode29 Lib/test/support/__init__.py:29: import types I've just noticed this leftover from some ...
2 years, 3 months ago #7
Martin Panter
https://bugs.python.org/review/23883/diff/15153/Doc/library/test.rst File Doc/library/test.rst (right): https://bugs.python.org/review/23883/diff/15153/Doc/library/test.rst#newcode588 Doc/library/test.rst:588: based on whether they match public name convention and ...
2 years, 3 months ago #8
Unit03
http://bugs.python.org/review/23883/diff/15153/Doc/library/test.rst File Doc/library/test.rst (right): http://bugs.python.org/review/23883/diff/15153/Doc/library/test.rst#newcode588 Doc/library/test.rst:588: based on whether they match public name convention and ...
2 years, 3 months ago #9
Martin Panter
https://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py File Lib/test/test_support.py (right): https://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py#newcode319 Lib/test/test_support.py:319: extra=extra) On 2015/07/05 11:53:43, Unit03 wrote: > On 2015/07/01 ...
2 years, 3 months ago #10
Unit03
http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py File Lib/test/test_support.py (right): http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py#newcode319 Lib/test/test_support.py:319: extra=extra) On 2015/07/18 14:09:19, vadmium wrote: > On 2015/07/05 ...
2 years, 2 months ago #11
Martin Panter
http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py File Lib/test/test_support.py (right): http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py#newcode319 Lib/test/test_support.py:319: extra=extra) On 2015/07/21 15:08:52, Unit03 wrote: > Or maybe ...
2 years, 2 months ago #12
Unit03
http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py File Lib/test/test_support.py (right): http://bugs.python.org/review/23883/diff/15153/Lib/test/test_support.py#newcode319 Lib/test/test_support.py:319: extra=extra) On 2015/07/21 15:56:25, vadmium wrote: > On 2015/07/21 ...
2 years, 2 months ago #13
storchaka_gmail.com
Besides few stylistic nitpicks the patch LGTM. http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py File Lib/test/support/__init__.py (right): http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py#newcode2255 Lib/test/support/__init__.py:2255: module_object = ...
1 year, 11 months ago #14
Unit03
1 year, 11 months ago #15
http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py
File Lib/test/support/__init__.py (right):

http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py#n...
Lib/test/support/__init__.py:2255: module_object = getattr(module, name)
On 2015/11/10 08:11:33, storchaka wrote:
> I would shorten module_object to just obj.

Done.

http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py#n...
Lib/test/support/__init__.py:2256: if (getattr(module_object, '__module__',
None) in name_of_module
On 2015/11/10 08:11:33, storchaka wrote:
> From PEP 8:
> """
> Make sure to indent the continued line appropriately.  The preferred
> place to break around a binary operator is *after* the operator, not
> before it.
> """

Done.

http://bugs.python.org/review/23883/diff/15251/Lib/test/support/__init__.py#n...
Lib/test/support/__init__.py:2257: or (not isinstance(module_object,
types.ModuleType)
On 2015/11/10 08:11:33, storchaka wrote:
> I would swap these two lines. "not hasattr(module_object, '__module__')"
handles
> adds a case of module-level constants, and "not isinstance(module_object,
> types.ModuleType)" makes an exception for module objects.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7