Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84075)

#23867: Argument Clinic: inline parsing code for 1-argument functions

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by storchaka+cpython
Modified:
3 years, 6 months ago
Reviewers:
meadori
CC:
haypo, larry, storchaka, ammar2, xtreak
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/clinic/arraymodule.c.h View 1 3 chunks +13 lines, -4 lines 0 comments Download
Modules/clinic/binascii.c.h View 1 12 chunks +12 lines, -12 lines 0 comments Download
Modules/clinic/_bz2module.c.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
Modules/clinic/cmathmodule.c.h View 1 21 chunks +41 lines, -21 lines 0 comments Download
Modules/clinic/_codecsmodule.c.h View 1 5 chunks +41 lines, -5 lines 0 comments Download
Modules/clinic/_lzmamodule.c.h View 1 4 chunks +10 lines, -4 lines 0 comments Download
Modules/clinic/posixmodule.c.h View 1 26 chunks +105 lines, -26 lines 0 comments Download
Modules/clinic/pwdmodule.c.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
Modules/clinic/pyexpat.c.h View 1 4 chunks +26 lines, -4 lines 0 comments Download
Modules/clinic/signalmodule.c.h View 1 4 chunks +22 lines, -4 lines 0 comments Download
Modules/clinic/spwdmodule.c.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
Modules/clinic/_ssl.c.h View 1 11 chunks +39 lines, -11 lines 0 comments Download
Modules/clinic/_tkinter.c.h View 1 11 chunks +107 lines, -11 lines 0 comments Download
Modules/clinic/unicodedata.c.h View 1 7 chunks +85 lines, -7 lines 0 comments Download
Modules/clinic/zlibmodule.c.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
Modules/_io/clinic/bufferedio.c.h View 1 3 chunks +4 lines, -3 lines 2 comments Download
Modules/_io/clinic/fileio.c.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
Modules/_io/clinic/textio.c.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
Objects/clinic/bytearrayobject.c.h View 1 4 chunks +10 lines, -4 lines 0 comments Download
Objects/clinic/bytesobject.c.h View 1 3 chunks +10 lines, -4 lines 0 comments Download
PC/clinic/msvcrtmodule.c.h View 1 5 chunks +43 lines, -5 lines 0 comments Download
PC/clinic/winreg.c.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
Python/bltinmodule.c View 1 1 chunk +1 line, -1 line 0 comments Download
Python/clinic/bltinmodule.c.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
Python/clinic/import.c.h View 1 6 chunks +36 lines, -6 lines 0 comments Download
Tools/clinic/clinic.py View 1 12 chunks +159 lines, -5 lines 10 comments Download

Messages

Total messages: 2
meadori
http://bugs.python.org/review/23867/diff/17123/Modules/_io/clinic/bufferedio.c.h File Modules/_io/clinic/bufferedio.c.h (right): http://bugs.python.org/review/23867/diff/17123/Modules/_io/clinic/bufferedio.c.h#newcode153 Modules/_io/clinic/bufferedio.c.h:153: size = PyNumber_AsSsize_t(arg, PyExc_OverflowError); `size` is defined anywhere. http://bugs.python.org/review/23867/diff/17123/Tools/clinic/clinic.py ...
3 years, 6 months ago #1
storchaka_gmail.com
3 years, 6 months ago #2
http://bugs.python.org/review/23867/diff/17123/Modules/_io/clinic/bufferedio.c.h
File Modules/_io/clinic/bufferedio.c.h (right):

http://bugs.python.org/review/23867/diff/17123/Modules/_io/clinic/bufferedio....
Modules/_io/clinic/bufferedio.c.h:153: size = PyNumber_AsSsize_t(arg,
PyExc_OverflowError);
On 2016/05/01 16:39:05, meadori wrote:
> `size` is defined anywhere.

Looks as there is a bug in "O&" converter in current code.

http://bugs.python.org/review/23867/diff/17123/Tools/clinic/clinic.py
File Tools/clinic/clinic.py (right):

http://bugs.python.org/review/23867/diff/17123/Tools/clinic/clinic.py#newcode808
Tools/clinic/clinic.py:808: goto exit;
On 2016/05/01 16:39:05, meadori wrote:
> This should have braces to be consistent with your issue26305 patch.

I'll add braces after committing issue26305 patch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+