Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

#23838: linecache and MemoryError

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by storchaka+cpython
Modified:
4 years, 9 months ago
Reviewers:
victor.stinner
CC:
AntoinePitrou, haypo, ezio.melotti, Michael Foord, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/linecache.py View 1 2 1 chunk +6 lines, -4 lines 2 comments Download
Lib/test/test_linecache.py View 1 2 1 chunk +15 lines, -3 lines 3 comments Download

Messages

Total messages: 2
victor.stinner_gmail.com
http://bugs.python.org/review/23838/diff/14410/Lib/linecache.py File Lib/linecache.py (right): http://bugs.python.org/review/23838/diff/14410/Lib/linecache.py#newcode44 Lib/linecache.py:44: return cache[filename][2] Add an empty line for readability. http://bugs.python.org/review/23838/diff/14410/Lib/test/test_linecache.py ...
4 years, 9 months ago #1
storchaka_gmail.com
4 years, 9 months ago #2
http://bugs.python.org/review/23838/diff/14410/Lib/linecache.py
File Lib/linecache.py (right):

http://bugs.python.org/review/23838/diff/14410/Lib/linecache.py#newcode44
Lib/linecache.py:44: return cache[filename][2]
On 2015/04/01 15:28:20, haypo wrote:
> Add an empty line for readability.

Done.

http://bugs.python.org/review/23838/diff/14410/Lib/test/test_linecache.py
File Lib/test/test_linecache.py (left):

http://bugs.python.org/review/23838/diff/14410/Lib/test/test_linecache.py#old...
Lib/test/test_linecache.py:173: def test_main():
On 2015/04/01 15:28:20, haypo wrote:
> Why did you remove test_main?

It's a part of long process to make tests discoverable (issue16748 and a lot of
other issues, mostly closed). I always convert tests to use unittest.main() when
touch them and have checked that it works. This is for 3.x only.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+