Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

#23735: Readline not adjusting width after resize with 6.3

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by carlos
Modified:
2 years, 6 months ago
Reviewers:
vadmium+py
CC:
r.david.murray, Charles-Fran├žois Natali, devnull_psf.upfronthosting.co.za, Thomas Kluyver, Martin Panter, storchaka, Josh.R, carlos_jampp.com, tiago_skewed.de, jwm_horde.net, Eric Price, christian.zommerfelds_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Total comments: 1

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/readline.c View 1 2 3 3 chunks +31 lines, -0 lines 0 comments Download
configure View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
configure.ac View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
pyconfig.h.in View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Martin Panter
http://bugs.python.org/review/23735/diff/15810/Modules/readline.c File Modules/readline.c (right): http://bugs.python.org/review/23735/diff/15810/Modules/readline.c#newcode1146 Modules/readline.c:1146: sigwinch_received = 0; Indentation is off
2 years, 12 months ago #1
Martin Panter
2 years, 6 months ago #2
http://bugs.python.org/review/23735/diff/16841/Modules/readline.c
File Modules/readline.c (right):

http://bugs.python.org/review/23735/diff/16841/Modules/readline.c#newcode939
Modules/readline.c:939: PyOS_setsig(SIGWINCH, readline_sigwinch_handler);
I would move this until the end of the function. I understand the technique is a
crude way of avoiding recursive signals, plus it would fix the order if the old
handler also restores itself.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7